Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1632159 > unrolled thread

Re: [PATCH] FS-Cache: print hexadecimal value for special cookies type

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] FS-Cache: print hexadecimal value for special cookies type David Howells <dhowells@redhat.com> - 2017-04-27 17:10 +0200
    Re: [PATCH] FS-Cache: print hexadecimal value for special cookies  type Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> - 2017-04-27 17:20 +0200
      Re: [PATCH] FS-Cache: print hexadecimal value for special cookies type David Howells <dhowells@redhat.com> - 2017-04-27 17:50 +0200

#1632159 — Re: [PATCH] FS-Cache: print hexadecimal value for special cookies type

Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> wrote:

> When building object-list.o, gcc 6 raises a warning on the sprintf call
> in fscache_objlist_show:
> 
>   CC      fs/fscache/object-list.o
> fs/fscache/object-list.c: In function ‘fscache_objlist_show’:
> fs/fscache/object-list.c:265:19: warning: ‘sprintf’ may write a
> terminating nul past the end of the destination [-Wformat-overflow=]
>     sprintf(_type, "%02u", cookie->def->type);
>                    ^~~~~~
> fs/fscache/object-list.c:265:4: note: ‘sprintf’ output between 3 and 4
> bytes into a destination of size 3
>     sprintf(_type, "%02u", cookie->def->type);
>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Moreover, the documentation says that we should have an hex value for
> special cookies (see Documentation/filesystems/caching/fscache.txt).
> 
> Printing hexadecimal value for special cookies fixes the overflow
> warning and complies with the documentation.

Fine by me.  We don't actually handle special type cookies at the moment, so
you're not going to see anything other than DT or IX for now anyway.

I'll push this in the next merge window if that's okay with you.

David

[toc] | [next] | [standalone]

#1632169 — Re: [PATCH] FS-Cache: print hexadecimal value for special cookies type

On Thu, 27 Apr 2017 16:03:45 +0100
David Howells <dhowells@redhat.com> wrote:

> Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> wrote:
> 
> > When building object-list.o, gcc 6 raises a warning on the sprintf call
> > in fscache_objlist_show:
> > 
> >   CC      fs/fscache/object-list.o
> > fs/fscache/object-list.c: In function ‘fscache_objlist_show’:
> > fs/fscache/object-list.c:265:19: warning: ‘sprintf’ may write a
> > terminating nul past the end of the destination [-Wformat-overflow=]
> >     sprintf(_type, "%02u", cookie->def->type);
> >                    ^~~~~~
> > fs/fscache/object-list.c:265:4: note: ‘sprintf’ output between 3 and 4
> > bytes into a destination of size 3
> >     sprintf(_type, "%02u", cookie->def->type);
> >     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > Moreover, the documentation says that we should have an hex value for
> > special cookies (see Documentation/filesystems/caching/fscache.txt).
> > 
> > Printing hexadecimal value for special cookies fixes the overflow
> > warning and complies with the documentation.  
> 
> Fine by me.  We don't actually handle special type cookies at the moment, so
> you're not going to see anything other than DT or IX for now anyway.
> 
> I'll push this in the next merge window if that's okay with you.
> 
Did you see the v2 of my patch (in which I keep the decimal value but
fix the buffer size) ? If special type cookies aren't handled, I guess
that this v1 is better, isn't it ?

[toc] | [prev] | [next] | [standalone]

#1632199

Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> wrote:

> Did you see the v2 of my patch (in which I keep the decimal value but
> fix the buffer size) ?

I did.

> If special type cookies aren't handled, I guess that this v1 is better,
> isn't it ?

Yes.  v1 is better.  The docs are right.

David

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web