Re: [PATCH] mtd: spi-nor: stm32: remove broken MODULE_ALIAS

From	Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mtd: spi-nor: stm32: remove broken MODULE_ALIAS
Date	2017-04-27 17:00 +0200
Message-ID	<tAT3I-20u-9@gated-at.bofh.it> (permalink)
References	<tAPCN-8aG-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Le 27/04/2017 à 13:09, Arnd Bergmann a écrit :
> The MODULE_ALIAS statement refers to a macro that has never been defined
> in this driver, causing a build error:
> 
> drivers/mtd/spi-nor/stm32-quadspi.c:694:150: error: expected ',' or ';' before 'DRIVER_NAME'
> 
> Unless there is a specific alias we need other then the driver name,
> we don't need an alias here and can simply remove the line to fix the
> build.
> 
> Fixes: dc5e400611c5 ("mtd: spi-nor: add driver for STM32 quad spi flash controller")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>

Thanks!

> ---
>  drivers/mtd/spi-nor/stm32-quadspi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/stm32-quadspi.c b/drivers/mtd/spi-nor/stm32-quadspi.c
> index 90d9152ddf98..1056e7408d2a 100644
> --- a/drivers/mtd/spi-nor/stm32-quadspi.c
> +++ b/drivers/mtd/spi-nor/stm32-quadspi.c
> @@ -691,7 +691,6 @@ static struct platform_driver stm32_qspi_driver = {
>  };
>  module_platform_driver(stm32_qspi_driver);
>  
> -MODULE_ALIAS("platform:" DRIVER_NAME);
>  MODULE_AUTHOR("Ludovic Barre <ludovic.barre@st.com>");
>  MODULE_DESCRIPTION("STMicroelectronics STM32 quad spi driver");
>  MODULE_LICENSE("GPL v2");
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mtd: spi-nor: stm32: remove broken MODULE_ALIAS Arnd Bergmann <arnd@arndb.de> - 2017-04-27 13:20 +0200
  Re: [PATCH] mtd: spi-nor: stm32: remove broken MODULE_ALIAS Ludovic BARRE <ludovic.barre@st.com> - 2017-04-27 14:20 +0200
    Re: [PATCH] mtd: spi-nor: stm32: remove broken MODULE_ALIAS Cyrille Pitchen <cyrille.pitchen@wedev4u.fr> - 2017-04-27 17:20 +0200
  Re: [PATCH] mtd: spi-nor: stm32: remove broken MODULE_ALIAS Cyrille Pitchen <cyrille.pitchen@wedev4u.fr> - 2017-04-27 17:00 +0200

csiph-web