Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1630195
| Path | csiph.com!news.redatomik.org!weretis.net!feeder4.news.weretis.net!newsfeed.CARNet.hr!news.spin.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Jan Kiszka <jan.kiszka@siemens.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 |
| Date | Tue, 25 Apr 2017 08:10:01 +0200 |
| Message-ID | <tA1PH-Rx-3@gated-at.bofh.it> (permalink) |
| References | <tzRQm-2Bd-9@gated-at.bofh.it> <tzSt4-33H-21@gated-at.bofh.it> |
| X-Original-To | Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Jonathan Cameron <jic23@kernel.org> |
| User-Agent | Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=utf-8 |
| Content-Transfer-Encoding | 7bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 29 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-iio@vger.kernel.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Sascha Weisenberger <sascha.weisenberger@siemens.com> |
| X-Original-Date | Tue, 25 Apr 2017 08:06:01 +0200 |
| X-Original-Message-ID | <d0882257-5fe9-4b1b-af3c-812972b68770@siemens.com> |
| X-Original-References | <6e0f0b52-27a1-0ce5-c217-3aa941babe63@siemens.com> <1493064330.24567.180.camel@linux.intel.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1630195 |
Show key headers only | View raw
On 2017-04-24 22:05, Andy Shevchenko wrote:
>> +{
>> + int ret;
>> + struct adc1x8s102_state *st;
>> +
>> + st = iio_priv(indio_dev);
>> +
>> + switch (m) {
>> + case IIO_CHAN_INFO_RAW:
>> + mutex_lock(&indio_dev->mlock);
>> + if (indio_dev->currentmode == INDIO_BUFFER_TRIGGERED)
>> {
>> + ret = -EBUSY;
>
>> + dev_warn(&st->spi->dev,
>> + "indio_dev->currentmode is
>> INDIO_BUFFER_TRIGGERED\n");
>
> Indentation?
Actually, this block needs to be converted to
iio_device_claim_direct_mode / iio_device_release_direct_mode, instead
of doing the old open-coded locking way.
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-24 21:30 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-04-24 22:10 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-04-24 22:20 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-24 22:40 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-24 22:40 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-24 23:30 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-25 07:50 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-25 11:50 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-25 13:00 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-04-25 13:30 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-04-25 13:40 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-25 14:20 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-04-25 14:40 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-25 15:50 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-25 18:20 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-04-26 11:30 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jonathan Cameron <jic23@kernel.org> - 2017-04-27 08:10 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jonathan Cameron <jic23@kernel.org> - 2017-04-27 08:10 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-25 08:10 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Peter Meerwald-Stadler <pmeerw@pmeerw.net> - 2017-04-25 09:40 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-25 11:30 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-25 11:40 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-04-25 13:30 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-04-25 14:30 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-26 08:00 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-26 12:30 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jonathan Cameron <jic23@kernel.org> - 2017-04-27 08:20 +0200
csiph-web