Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1630195
| From | Jan Kiszka <jan.kiszka@siemens.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 |
| Date | 2017-04-25 08:10 +0200 |
| Message-ID | <tA1PH-Rx-3@gated-at.bofh.it> (permalink) |
| References | <tzRQm-2Bd-9@gated-at.bofh.it> <tzSt4-33H-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 2017-04-24 22:05, Andy Shevchenko wrote:
>> +{
>> + int ret;
>> + struct adc1x8s102_state *st;
>> +
>> + st = iio_priv(indio_dev);
>> +
>> + switch (m) {
>> + case IIO_CHAN_INFO_RAW:
>> + mutex_lock(&indio_dev->mlock);
>> + if (indio_dev->currentmode == INDIO_BUFFER_TRIGGERED)
>> {
>> + ret = -EBUSY;
>
>> + dev_warn(&st->spi->dev,
>> + "indio_dev->currentmode is
>> INDIO_BUFFER_TRIGGERED\n");
>
> Indentation?
Actually, this block needs to be converted to
iio_device_claim_direct_mode / iio_device_release_direct_mode, instead
of doing the old open-coded locking way.
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-24 21:30 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-04-24 22:10 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-04-24 22:20 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-24 22:40 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-24 22:40 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-24 23:30 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-25 07:50 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-25 11:50 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-25 13:00 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-04-25 13:30 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-04-25 13:40 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-25 14:20 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-04-25 14:40 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-25 15:50 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-25 18:20 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-04-26 11:30 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jonathan Cameron <jic23@kernel.org> - 2017-04-27 08:10 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jonathan Cameron <jic23@kernel.org> - 2017-04-27 08:10 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-25 08:10 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Peter Meerwald-Stadler <pmeerw@pmeerw.net> - 2017-04-25 09:40 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-25 11:30 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-25 11:40 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-04-25 13:30 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-04-25 14:30 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-26 08:00 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-26 12:30 +0200
Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Jonathan Cameron <jic23@kernel.org> - 2017-04-27 08:20 +0200
csiph-web