Path: csiph.com!news.redatomik.org!weretis.net!feeder4.news.weretis.net!newsfeed.CARNet.hr!news.spin.it!bofh.it!news.nic.it!robomod From: Jan Kiszka Newsgroups: linux.kernel Subject: Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 Date: Tue, 25 Apr 2017 08:10:01 +0200 Message-ID: References: X-Original-To: Andy Shevchenko , Jonathan Cameron User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 29 Organization: linux.* mail to news gateway X-Original-Cc: linux-iio@vger.kernel.org, Linux Kernel Mailing List , Sascha Weisenberger X-Original-Date: Tue, 25 Apr 2017 08:06:01 +0200 X-Original-Message-ID: X-Original-References: <6e0f0b52-27a1-0ce5-c217-3aa941babe63@siemens.com> <1493064330.24567.180.camel@linux.intel.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1630195 On 2017-04-24 22:05, Andy Shevchenko wrote: >> +{ >> + int ret; >> + struct adc1x8s102_state *st; >> + >> + st = iio_priv(indio_dev); >> + >> + switch (m) { >> + case IIO_CHAN_INFO_RAW: >> + mutex_lock(&indio_dev->mlock); >> + if (indio_dev->currentmode == INDIO_BUFFER_TRIGGERED) >> { >> + ret = -EBUSY; > >> + dev_warn(&st->spi->dev, >> + "indio_dev->currentmode is >> INDIO_BUFFER_TRIGGERED\n"); > > Indentation? Actually, this block needs to be converted to iio_device_claim_direct_mode / iio_device_release_direct_mode, instead of doing the old open-coded locking way. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux