Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1578770

[PATCH v3 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable

Show all headers | View raw

When the sunvnet_common code was split out for use by both sunvnet
and the newer ldmvsw, it was made into a static kernel library, which
limits the usefulness of sunvnet and ldmvsw as loadables, since most
of the real work is being done in the shared code.  Also, this is
simply dead code in kernels that aren't running the LDoms.

This patch makes the sunvnet_common into a dynamically loadable
module and makes sunvnet and ldmvsw dependent on sunvnet_common.

Signed-off-by: Shannon Nelson <shannon.nelson@oracle.com>
---
 drivers/net/ethernet/sun/Kconfig          |    8 ++++++--
 drivers/net/ethernet/sun/sunvnet_common.c |    5 +++++
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/sun/Kconfig b/drivers/net/ethernet/sun/Kconfig
index a4b40e3..a7d91da 100644
--- a/drivers/net/ethernet/sun/Kconfig
+++ b/drivers/net/ethernet/sun/Kconfig
@@ -70,19 +70,23 @@ config CASSINI
 	  <http://docs.oracle.com/cd/E19113-01/giga.ether.pci/817-4341-10/817-4341-10.pdf>.
 
 config SUNVNET_COMMON
-	bool
+	tristate "Common routines to support Sun Virtual Networking"
 	depends on SUN_LDOMS
-	default y if SUN_LDOMS
+	default m if SUN_LDOMS
 
 config SUNVNET
 	tristate "Sun Virtual Network support"
+	default m
 	depends on SUN_LDOMS
+	depends on SUNVNET_COMMON
 	---help---
 	  Support for virtual network devices under Sun Logical Domains.
 
 config LDMVSW
 	tristate "Sun4v LDoms Virtual Switch support"
+	default m
 	depends on SUN_LDOMS
+	depends on SUNVNET_COMMON
 	---help---
 	  Support for virtual switch devices under Sun4v Logical Domains.
 	  This driver adds a network interface for every vsw-port node
diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drivers/net/ethernet/sun/sunvnet_common.c
index 191c8ad..c71f000 100644
--- a/drivers/net/ethernet/sun/sunvnet_common.c
+++ b/drivers/net/ethernet/sun/sunvnet_common.c
@@ -37,6 +37,11 @@
  */
 #define	VNET_MAX_RETRIES	10
 
+MODULE_AUTHOR("David S. Miller (davem@davemloft.net)");
+MODULE_DESCRIPTION("Sun LDOM virtual network support library");
+MODULE_LICENSE("GPL");
+MODULE_VERSION("1.1");
+
 static int __vnet_tx_trigger(struct vnet_port *port, u32 start);
 static void vnet_port_reset(struct vnet_port *port);
 
-- 
1.7.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 net-next 0/9] sunvnet driver updates Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-10 19:40 +0100
  [PATCH v3 net-next 6/9] sunvnet: straighten up message event handling logic Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-10 19:40 +0100
  [PATCH v3 net-next 8/9] ldmvsw: update and simplify version string Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-10 19:50 +0100
  [PATCH v3 net-next 5/9] sunvnet: add memory barrier before check for tx enable Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-10 19:50 +0100
  [PATCH v3 net-next 2/9] sunvnet: remove unused variable in maybe_tx_wakeup Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-10 19:50 +0100
  [PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool support Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-10 20:00 +0100
    Re: [PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool  support Stephen Hemminger <stephen@networkplumber.org> - 2017-02-11 01:30 +0100
      Re: [PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool  support David Miller <davem@davemloft.net> - 2017-02-12 03:10 +0100
        Re: [PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool  support Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-13 18:20 +0100
  [PATCH v3 net-next 9/9] ldmvsw: disable tso and gso for bridge operations Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-10 20:00 +0100
  [PATCH v3 net-next 3/9] sunvnet: update version and version printing Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-10 20:00 +0100
  [PATCH v3 net-next 7/9] sunvnet: remove extra rcu_read_unlocks Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-10 20:10 +0100
  [PATCH v3 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-10 21:20 +0100
    Re: [PATCH v3 net-next 1/9] sunvnet: make sunvnet common code  dynamically loadable Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-02-12 12:20 +0100
      Re: [PATCH v3 net-next 1/9] sunvnet: make sunvnet common code  dynamically loadable Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-13 18:20 +0100

csiph-web