Re: [PATCH] PCI/MSI: Return error code if memory allocation fails

From	Bjorn Helgaas <helgaas@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] PCI/MSI: Return error code if memory allocation fails
Date	2017-02-10 21:20 +0100
Message-ID	<t9pPH-8bb-5@gated-at.bofh.it> (permalink)
References	<t4gtI-5Mm-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jan 27, 2017 at 04:14:53PM +0100, Christophe JAILLET wrote:
> If 'alloc_msi_entry()' fails, a few lines above, we free resources and set
> 'ret = -ENOMEM'.
> 
> However, the function returns 0, inconditionaly.
> Returns the error code instead.
> 
> Fixes: e75eafb9b039 ("genirq/msi: Switch to new irq spreading infrastructure")
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Applied to pci/msi for v4.11, thanks!

> ---
>  drivers/pci/msi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
> index b6785c8be44d..0f77b38f03dd 100644
> --- a/drivers/pci/msi.c
> +++ b/drivers/pci/msi.c
> @@ -731,7 +731,7 @@ static int msix_setup_entries(struct pci_dev *dev, void __iomem *base,
>  	ret = 0;
>  out:
>  	kfree(masks);
> -	return 0;
> +	return ret;
>  }
>  
>  static void msix_program_entries(struct pci_dev *dev,
> -- 
> 2.9.3
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] PCI/MSI: Return error code if memory allocation fails Bjorn Helgaas <helgaas@kernel.org> - 2017-02-10 21:20 +0100

csiph-web