Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1579151
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool support |
| Date | 2017-02-12 03:10 +0100 |
| Message-ID | <t9RLY-cs-9@gated-at.bofh.it> (permalink) |
| References | <t9ogV-77S-9@gated-at.bofh.it> <t9oAh-7fF-1@gated-at.bofh.it> <t9tJD-26C-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 10 Feb 2017 16:22:08 -0800
> On Fri, 10 Feb 2017 09:38:20 -0800
> Shannon Nelson <shannon.nelson@oracle.com> wrote:
>
>> +static void vsw_get_ethtool_stats(struct net_device *dev,
>> + struct ethtool_stats *estats, u64 *data)
>> +{
>> + int i = 0;
>> +
>> + data[i++] = dev->stats.rx_packets;
>> + data[i++] = dev->stats.tx_packets;
>> + data[i++] = dev->stats.rx_bytes;
>> + data[i++] = dev->stats.tx_bytes;
>> + data[i++] = dev->stats.rx_errors;
>> + data[i++] = dev->stats.tx_errors;
>> + data[i++] = dev->stats.rx_dropped;
>> + data[i++] = dev->stats.tx_dropped;
>> + data[i++] = dev->stats.multicast;
>
> Please do not duplicate regular network statistics into ethtool.
> This doesn't really add any value.
Agreed.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 net-next 0/9] sunvnet driver updates Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-10 19:40 +0100
[PATCH v3 net-next 6/9] sunvnet: straighten up message event handling logic Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-10 19:40 +0100
[PATCH v3 net-next 8/9] ldmvsw: update and simplify version string Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-10 19:50 +0100
[PATCH v3 net-next 5/9] sunvnet: add memory barrier before check for tx enable Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-10 19:50 +0100
[PATCH v3 net-next 2/9] sunvnet: remove unused variable in maybe_tx_wakeup Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-10 19:50 +0100
[PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool support Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-10 20:00 +0100
Re: [PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool support Stephen Hemminger <stephen@networkplumber.org> - 2017-02-11 01:30 +0100
Re: [PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool support David Miller <davem@davemloft.net> - 2017-02-12 03:10 +0100
Re: [PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool support Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-13 18:20 +0100
[PATCH v3 net-next 9/9] ldmvsw: disable tso and gso for bridge operations Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-10 20:00 +0100
[PATCH v3 net-next 3/9] sunvnet: update version and version printing Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-10 20:00 +0100
[PATCH v3 net-next 7/9] sunvnet: remove extra rcu_read_unlocks Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-10 20:10 +0100
[PATCH v3 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-10 21:20 +0100
Re: [PATCH v3 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-02-12 12:20 +0100
Re: [PATCH v3 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable Shannon Nelson <shannon.nelson@oracle.com> - 2017-02-13 18:20 +0100
csiph-web