Re: [PATCH] ALSA: x86: mark hdmi suspend/resume functions as __maybe_unused

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!news.szaf.org!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Takashi Iwai <tiwai@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ALSA: x86: mark hdmi suspend/resume functions as __maybe_unused
Date	Tue, 07 Feb 2017 16:20:03 +0100
Message-ID	<t8fIL-4zi-41@gated-at.bofh.it> (permalink)
References	<t8ejE-3wo-9@gated-at.bofh.it> <t8eWl-41t-1@gated-at.bofh.it>
X-Original-To	"Takashi Sakamoto" <o-takashi@sakamocchi.jp>
User-Agent	Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.8 Emacs/25.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version	1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type	text/plain; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	62
Organization	linux.* mail to news gateway
X-Original-Cc	"Arnd Bergmann" <arnd@arndb.de>, "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>, "Jerome Anand" <jerome.anand@intel.com>, "Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>, <linux-kernel@vger.kernel.org>
X-Original-Date	Tue, 07 Feb 2017 16:10:33 +0100
X-Original-Message-ID	<s5hshnqavfa.wl-tiwai@suse.de>
X-Original-References	<20170207133918.1085873-1-arnd@arndb.de> <14768fe7-9b3a-ed4d-0c15-6ddae07f6cba@sakamocchi.jp>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1575801

Show key headers only | View raw

On Tue, 07 Feb 2017 15:19:47 +0100,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> On Feb 7 2016 22:38, Arnd Bergmann wrote:
> > The two functions are unused when CONFIG_PM_SLEEP is disabled:
> >
> > sound/x86/intel_hdmi_audio.c:1633:12: error: 'hdmi_lpe_audio_resume' defined but not used [-Werror=unused-function]
> > sound/x86/intel_hdmi_audio.c:1622:12: error: 'hdmi_lpe_audio_suspend' defined but not used [-Werror=unused-function]
> >
> > Marking them as __maybe_unused avoids the warning without introducing an
> > ugly #ifdef.
> >
> > Fixes: 182cdf23dbf6 ("ALSA: x86: Implement runtime PM")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> >  sound/x86/intel_hdmi_audio.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c
> > index 8978dc9bf579..0d19a4994bac 100644
> > --- a/sound/x86/intel_hdmi_audio.c
> > +++ b/sound/x86/intel_hdmi_audio.c
> > @@ -1619,7 +1619,7 @@ static int hdmi_lpe_audio_runtime_suspend(struct device *dev)
> >  	return 0;
> >  }
> >
> > -static int hdmi_lpe_audio_suspend(struct device *dev)
> > +static int __maybe_unused hdmi_lpe_audio_suspend(struct device *dev)
> >  {
> >  	struct snd_intelhad *ctx = dev_get_drvdata(dev);
> >  	int err;
> > @@ -1630,7 +1630,7 @@ static int hdmi_lpe_audio_suspend(struct device *dev)
> >  	return err;
> >  }
> >
> > -static int hdmi_lpe_audio_resume(struct device *dev)
> > +static int __maybe_unused hdmi_lpe_audio_resume(struct device *dev)
> >  {
> >  	struct snd_intelhad *ctx = dev_get_drvdata(dev);
> 
> In this case, in this subsystem, we can see codes to pre-process the
> function calls to NULL and the function definition is omitted. This is
> a sample:
> https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/tree/sound/pci/hda/patch_sigmatel.c#n4427
> 
> Let us apply the same idea to this module?

In the case of HD-audio, the dependency is more complex, and
__maybe_unused will omit the warning we really want to see if the
dependency is broken.  So, better not touch it.

For a simpler driver, it's fine to take this approach, yes.
But you don't have to rush now unless you've seen the similar warnings
and need some fix.  It's already close to the merge window, and such a
cleanup would bring an error by mistake.


thanks,

Takashi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ALSA: x86: mark hdmi suspend/resume functions as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2017-02-07 14:50 +0100
  Re: [PATCH] ALSA: x86: mark hdmi suspend/resume functions as __maybe_unused Takashi Iwai <tiwai@suse.de> - 2017-02-07 15:20 +0100
  Re: [PATCH] ALSA: x86: mark hdmi suspend/resume functions as  __maybe_unused Takashi Sakamoto <o-takashi@sakamocchi.jp> - 2017-02-07 15:30 +0100
    Re: [PATCH] ALSA: x86: mark hdmi suspend/resume functions as __maybe_unused Takashi Iwai <tiwai@suse.de> - 2017-02-07 16:20 +0100

csiph-web