Re: [LTP] [lkp-robot] [fs] 99f64a2676: ltp.creat08.fail & ltp.open10.fail

From	Cyril Hrubis <chrubis@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [LTP] [lkp-robot] [fs] 99f64a2676: ltp.creat08.fail & ltp.open10.fail
Date	2017-02-07 16:20 +0100
Message-ID	<t8fIK-4zi-23@gated-at.bofh.it> (permalink)
References	<t8fIK-4zi-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi!
> FYI, we noticed the following commit:
> 
> commit: 99f64a2676f0bec4ad32e39fc76eb0914ee091b8 ("fs: Harden against open(..., O_CREAT, 02777) in a setgid directory")
> https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git vfs/suid
> 
> in testcase: ltp
> with following parameters:
> 
> 	test: ltplite
> 
> test-description: The LTP testsuite contains a collection of tools for testing the Linux kernel and related features.
> test-url: http://linux-test-project.github.io/

Looking at the testcases in question these are testing exactly the
corner case the patch is fixing.

So the tests needs to be fixed once this patch hits mainline. And the
best fix is to expect the SGID flag to be cleared on newer kernels.

-- 
Cyril Hrubis
chrubis@suse.cz

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [LTP] [lkp-robot] [fs] 99f64a2676: ltp.creat08.fail &  ltp.open10.fail Cyril Hrubis <chrubis@suse.cz> - 2017-02-07 16:20 +0100

csiph-web