Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1575764

Re: [PATCH] ALSA: x86: mark hdmi suspend/resume functions as __maybe_unused

Show all headers | View raw

Hi,

On Feb 7 2016 22:38, Arnd Bergmann wrote:
> The two functions are unused when CONFIG_PM_SLEEP is disabled:
>
> sound/x86/intel_hdmi_audio.c:1633:12: error: 'hdmi_lpe_audio_resume' defined but not used [-Werror=unused-function]
> sound/x86/intel_hdmi_audio.c:1622:12: error: 'hdmi_lpe_audio_suspend' defined but not used [-Werror=unused-function]
>
> Marking them as __maybe_unused avoids the warning without introducing an
> ugly #ifdef.
>
> Fixes: 182cdf23dbf6 ("ALSA: x86: Implement runtime PM")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  sound/x86/intel_hdmi_audio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c
> index 8978dc9bf579..0d19a4994bac 100644
> --- a/sound/x86/intel_hdmi_audio.c
> +++ b/sound/x86/intel_hdmi_audio.c
> @@ -1619,7 +1619,7 @@ static int hdmi_lpe_audio_runtime_suspend(struct device *dev)
>  	return 0;
>  }
>
> -static int hdmi_lpe_audio_suspend(struct device *dev)
> +static int __maybe_unused hdmi_lpe_audio_suspend(struct device *dev)
>  {
>  	struct snd_intelhad *ctx = dev_get_drvdata(dev);
>  	int err;
> @@ -1630,7 +1630,7 @@ static int hdmi_lpe_audio_suspend(struct device *dev)
>  	return err;
>  }
>
> -static int hdmi_lpe_audio_resume(struct device *dev)
> +static int __maybe_unused hdmi_lpe_audio_resume(struct device *dev)
>  {
>  	struct snd_intelhad *ctx = dev_get_drvdata(dev);

In this case, in this subsystem, we can see codes to pre-process the 
function calls to NULL and the function definition is omitted. This is a 
sample:
https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/tree/sound/pci/hda/patch_sigmatel.c#n4427

Let us apply the same idea to this module?


Thanks

Takashi Sakamoto

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ALSA: x86: mark hdmi suspend/resume functions as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2017-02-07 14:50 +0100
  Re: [PATCH] ALSA: x86: mark hdmi suspend/resume functions as __maybe_unused Takashi Iwai <tiwai@suse.de> - 2017-02-07 15:20 +0100
  Re: [PATCH] ALSA: x86: mark hdmi suspend/resume functions as  __maybe_unused Takashi Sakamoto <o-takashi@sakamocchi.jp> - 2017-02-07 15:30 +0100
    Re: [PATCH] ALSA: x86: mark hdmi suspend/resume functions as __maybe_unused Takashi Iwai <tiwai@suse.de> - 2017-02-07 16:20 +0100

csiph-web