Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1574583

Re: [PATCH V2 2/2] netfilter: ctnetlink: Fix regression in CTA_HELP processing

From Pablo Neira Ayuso <pablo@netfilter.org>
Newsgroups linux.kernel
Subject Re: [PATCH V2 2/2] netfilter: ctnetlink: Fix regression in CTA_HELP processing
Date 2017-02-06 12:50 +0100
Message-ID <t7PXY-4pP-23@gated-at.bofh.it> (permalink)
References <t41bk-4KV-17@gated-at.bofh.it> <t41bk-4KV-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Jan 26, 2017 at 02:49:44PM -0800, Kevin Cernekee wrote:
> Prior to Linux 4.4, it was usually harmless to send a CTA_HELP attribute
> containing the name of the current helper.  That is no longer the case:
> as of Linux 4.4, if ctnetlink_change_helper() returns an error from
> the ct->master check, processing of the request will fail, skipping the
> NFQA_EXP attribute (if present).
> 
> This patch changes the behavior to improve compatibility with user
> programs that expect the kernel interface to work the way it did prior
> to Linux 4.4.  If a user program specifies CTA_HELP but the argument
> matches the current conntrack helper name, ignore it instead of generating
> an error.

Also applied, thanks Kevin.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH V2 2/2] netfilter: ctnetlink: Fix regression in CTA_HELP  processing Pablo Neira Ayuso <pablo@netfilter.org> - 2017-02-06 12:50 +0100

csiph-web