Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1574583 > unrolled thread

Re: [PATCH V2 2/2] netfilter: ctnetlink: Fix regression in CTA_HELP processing

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH V2 2/2] netfilter: ctnetlink: Fix regression in CTA_HELP  processing Pablo Neira Ayuso <pablo@netfilter.org> - 2017-02-06 12:50 +0100

#1574583 — Re: [PATCH V2 2/2] netfilter: ctnetlink: Fix regression in CTA_HELP processing

On Thu, Jan 26, 2017 at 02:49:44PM -0800, Kevin Cernekee wrote:
> Prior to Linux 4.4, it was usually harmless to send a CTA_HELP attribute
> containing the name of the current helper.  That is no longer the case:
> as of Linux 4.4, if ctnetlink_change_helper() returns an error from
> the ct->master check, processing of the request will fail, skipping the
> NFQA_EXP attribute (if present).
> 
> This patch changes the behavior to improve compatibility with user
> programs that expect the kernel interface to work the way it did prior
> to Linux 4.4.  If a user program specifies CTA_HELP but the argument
> matches the current conntrack helper name, ignore it instead of generating
> an error.

Also applied, thanks Kevin.

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web