Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1574368
| Path | csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Eddie Cai <eddie.cai.linux@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board |
| Date | Mon, 06 Feb 2017 07:00:02 +0100 |
| Message-ID | <t7Kvg-O2-3@gated-at.bofh.it> (permalink) |
| References | <t7H4l-75U-1@gated-at.bofh.it> <t7H4l-75U-3@gated-at.bofh.it> <t7HH3-7jE-7@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=v2TwGVS6a7Lxa5HI6D2BneZP07lKXYJhv3JJ+XdupKc=; b=FbGLYrA8NzMGpzYNwU7vA+KZV8Ipg5k6mVzA649Ul1FpDeeo3vL18wUaNR0krg/6XH aTMB89uzOM5h4AMsq/Meq3x1ZsGW6NUPa6nL2G5SBPnd2zNKeA7gqm2CEytLjOtyOI3v DSwIqK9ALTq/k2bVSL8/DuGyMKV14aPIUms6HQxFxa9JVgOMVRGG+yAw/LyflSSizZjM LIbEBS+5esS3S2FX9HtpulSeI9AJt6OkGZKO9RjzUuSY34SVXQ5CzzpajU++pWcA1DMl LUuxGN7dPjLsvkkFqDL+H/oIl5VeBqHMNP9crZ+ZOoDklAf3sKEut6c61eGw2MKXZuxV 2J9g== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=v2TwGVS6a7Lxa5HI6D2BneZP07lKXYJhv3JJ+XdupKc=; b=S0DLFDkzLdec9zlzAwqt9p0XGDJC4HqwGZ9gFomG6Z/+Xpi/qnwMYHjFdZCfjuOEFf oFxif4WxAiY3sRO4t6n+u+bdIvjnAma18Y7nqWoa4DhZWwsMMVnBLo+AERSv4lF3jVSE VRUw6CXZYlVZ4e2xUeHtCwAynnXimZgVczyHBvvgwbAV258DKg5BWkkSICJ1zU+aUU+5 2pdjt2q+xObt/6n3wdp+98KpJtDb7B6xhZaWWEt2aypqSr0ZF8PEP2+azHrd7hBktJLh 6c+yL6zRmx4h4pD+upnua1SgpGzwxPQnesyfjNKI6SD8m+PCAeLESju3GJfVefhxvXM1 4OaQ== |
| X-Gm-Message-State | AMke39niptiXJHIzVtEMmaWtUN+1yDEBKHM5y+Q9JYUWYKomVgVkzSaQEZXchJEMVceMcbOlfCihIx/3JFhudg== |
| X-Received | by 10.237.34.150 with SMTP id p22mr7540609qtc.76.1486360322396; Sun, 05 Feb 2017 21:52:02 -0800 (PST) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 30 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | robh+dt@kernel.org, mark.rutland@arm.com, Heiko Stuebner <heiko@sntech.de>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, linux-rockchip@lists.infradead.org, Eddie Cai <eddie.cai@rock-chips.com>, linux-arm-kernel@lists.infradead.org |
| X-Original-Date | Mon, 6 Feb 2017 13:52:01 +0800 |
| X-Original-Message-ID | <CAJrj+DPVw9uZ9VS_mS4U9t8rSKxoQJSzbQK=DgtuVecOoX3u8A@mail.gmail.com> |
| X-Original-References | <1486347287-31051-1-git-send-email-eddie.cai@rock-chips.com> <1486347287-31051-3-git-send-email-eddie.cai@rock-chips.com> <20170206025435.GA32506@lunn.ch> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1574368 |
Show key headers only | View raw
Hi Andrew
2017-02-06 10:54 GMT+08:00 Andrew Lunn <andrew@lunn.ch>:
> Hi Eddie
>
>> + button@0 {
>> + gpios = <&gpio0 5 GPIO_ACTIVE_LOW>;
>> + linux,code = <116>;
>
> It is a good idea to use include/dt-bindings/input/input.h
>
> and then you can replace <116> with < KEY_POWER > which is more
> readable.
Thanks, I will modify it in next version.
>
>> + label = "GPIO Key Power";
>> + linux,input-type = <1>;
>
> < EV_KEY >
>
>> + gpio-key,wakeup = <1>;
>
> This has been replace with wakeup-source.
Thanks, I will modify it in next version
>
>> + debounce-interval = <100>;
>> + };
>> + };
>
> Andrew
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V2 0/2] Add support for RK3288 Tinker board Eddie Cai <eddie.cai.linux@gmail.com> - 2017-02-06 03:20 +0100
[PATCH V2 1/2] dt-bindings: add Asus Tinker board Eddie Cai <eddie.cai.linux@gmail.com> - 2017-02-06 03:20 +0100
Re: [PATCH V2 1/2] dt-bindings: add Asus Tinker board Rob Herring <robh@kernel.org> - 2017-02-09 00:10 +0100
[PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Eddie Cai <eddie.cai.linux@gmail.com> - 2017-02-06 03:20 +0100
Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Andrew Lunn <andrew@lunn.ch> - 2017-02-06 04:00 +0100
Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Eddie Cai <eddie.cai.linux@gmail.com> - 2017-02-06 07:00 +0100
Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Heiko Stuebner <heiko@sntech.de> - 2017-02-09 00:40 +0100
Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Andy Yan <andy.yan@rock-chips.com> - 2017-02-09 03:00 +0100
csiph-web