Path: csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From: Eddie Cai <eddie.cai.linux@gmail.com>
Newsgroups: linux.kernel
Subject: Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board
Date: Mon, 06 Feb 2017 07:00:02 +0100
Message-ID: <t7Kvg-O2-3@gated-at.bofh.it>
References: <t7H4l-75U-1@gated-at.bofh.it> <t7H4l-75U-3@gated-at.bofh.it> <t7HH3-7jE-7@gated-at.bofh.it>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Sender: robomod@news.nic.it
Approved: robomod@news.nic.it
Lines: 30
Organization: linux.* mail to news gateway
Xref: csiph.com linux.kernel:1574368

Hi Andrew

2017-02-06 10:54 GMT+08:00 Andrew Lunn <andrew@lunn.ch>:
> Hi Eddie
>
>> +             button@0 {
>> +                     gpios = <&gpio0 5 GPIO_ACTIVE_LOW>;
>> +                     linux,code = <116>;
>
> It is a good idea to use include/dt-bindings/input/input.h
>
> and then you can replace <116> with < KEY_POWER > which is more
> readable.
Thanks, I will modify it in next version.
>
>> +                     label = "GPIO Key Power";
>> +                     linux,input-type = <1>;
>
> < EV_KEY >
>
>> +                     gpio-key,wakeup = <1>;
>
> This has been replace with wakeup-source.
Thanks, I will modify it in next version
>
>> +                     debounce-interval = <100>;
>> +             };
>> +     };
>
>   Andrew