Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1574334

Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board
Date 2017-02-06 04:00 +0100
Message-ID <t7HH3-7jE-7@gated-at.bofh.it> (permalink)
References <t7H4l-75U-1@gated-at.bofh.it> <t7H4l-75U-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Eddie

> +		button@0 {
> +			gpios = <&gpio0 5 GPIO_ACTIVE_LOW>;
> +			linux,code = <116>;

It is a good idea to use include/dt-bindings/input/input.h

and then you can replace <116> with < KEY_POWER > which is more
readable.

> +			label = "GPIO Key Power";
> +			linux,input-type = <1>;

< EV_KEY >

> +			gpio-key,wakeup = <1>;

This has been replace with wakeup-source.

> +			debounce-interval = <100>;
> +		};
> +	};

  Andrew

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH V2 0/2] Add support for RK3288 Tinker board Eddie Cai <eddie.cai.linux@gmail.com> - 2017-02-06 03:20 +0100
  [PATCH V2 1/2] dt-bindings: add Asus Tinker board Eddie Cai <eddie.cai.linux@gmail.com> - 2017-02-06 03:20 +0100
    Re: [PATCH V2 1/2] dt-bindings: add Asus Tinker board Rob Herring <robh@kernel.org> - 2017-02-09 00:10 +0100
  [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Eddie Cai <eddie.cai.linux@gmail.com> - 2017-02-06 03:20 +0100
    Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker  board Andrew Lunn <andrew@lunn.ch> - 2017-02-06 04:00 +0100
      Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Eddie Cai <eddie.cai.linux@gmail.com> - 2017-02-06 07:00 +0100
    Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Heiko Stuebner <heiko@sntech.de> - 2017-02-09 00:40 +0100
    Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker  board Andy Yan <andy.yan@rock-chips.com> - 2017-02-09 03:00 +0100

csiph-web