Re: [PATCH v3] platform: chrome: Add Tablet Switch ACPI driver

From	Benson Leung <bleung@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] platform: chrome: Add Tablet Switch ACPI driver
Date	2017-02-01 19:40 +0100
Message-ID	<t67YZ-Zl-3@gated-at.bofh.it> (permalink)
References	<t5tId-1Kd-1@gated-at.bofh.it> <t5tRT-1Nt-7@gated-at.bofh.it>
Organization	Google

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Thanks Gwendal for adding the resume handling. Glad to have been able to
catch that early.

On 01/30/2017 03:47 PM, Gwendal Grignou wrote:
> Add a kernel driver for GOOG0006, an ACPI driver reporting an event when
> the tablet switch status changes.
> 
> On an ACPI based convertible chromebook check evtest display tablet mode
> switch changes:
> Available devices:
> ..
> /dev/input/event3:      Tablet Mode Switch
> ..
> Testing ... (interrupt to exit)
> Event: time 1484879712.604360, type 5 (EV_SW), code 1 (SW_TABLET_MODE),
> value 1
> Event: time 1484879712.604360, -------------- SYN_REPORT ------------
> Event: time 1484879715.132228, type 5 (EV_SW), code 1 (SW_TABLET_MODE),
> value 0
> Event: time 1484879715.132228, -------------- SYN_REPORT ------------
> ...
> Check state is updated at resume time when different from suspend time.
> 
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>

Acked-by: Benson Leung <bleung@chromium.org>

New driver looks good to me.
I'll add this to my tree, once I get it up and running.

-- 
Benson Leung
Senior Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] platform: chrome: Add Tablet Switch ACPI driver Gwendal Grignou <gwendal@chromium.org> - 2017-01-30 20:40 +0100
  Re: [PATCH v2] platform: chrome: Add Tablet Switch ACPI driver Benson Leung <bleung@chromium.org> - 2017-01-31 00:40 +0100
    [PATCH v3] platform: chrome: Add Tablet Switch ACPI driver Gwendal Grignou <gwendal@chromium.org> - 2017-01-31 00:50 +0100
      Re: [PATCH v3] platform: chrome: Add Tablet Switch ACPI driver Benson Leung <bleung@chromium.org> - 2017-02-01 19:40 +0100

csiph-web