Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1570182

Re: [PATCH v2] platform: chrome: Add Tablet Switch ACPI driver

From Benson Leung <bleung@chromium.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2] platform: chrome: Add Tablet Switch ACPI driver
Date 2017-01-31 00:40 +0100
Message-ID <t5tId-1Kd-1@gated-at.bofh.it> (permalink)
References <t4pdD-2Gf-3@gated-at.bofh.it> <t5pXY-7V1-21@gated-at.bofh.it>
Organization Google

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Gwendal,

Overall, this looks good to me, but please make sure this is based on
upstream, and not the ChromeOS kernel trees.

On 01/30/2017 11:30 AM, Gwendal Grignou wrote:
> Add a kernel driver for GOOG0006, an ACPI driver reporting an event when
> the tablet switch status changes.
> 
> On an ACPI based convertible chromebook check evtest display tablet mode
> switch changes:
> Available devices:
> ..
> /dev/input/event3:      Tablet Mode Switch
> ..
> Testing ... (interrupt to exit)
> Event: time 1484879712.604360, type 5 (EV_SW), code 1 (SW_TABLET_MODE),
> value 1
> Event: time 1484879712.604360, -------------- SYN_REPORT ------------
> Event: time 1484879715.132228, type 5 (EV_SW), code 1 (SW_TABLET_MODE),
> value 0
> Event: time 1484879715.132228, -------------- SYN_REPORT ------------
> ...
> Check state is updated at resume time when different from suspend time.
> 
> Change-Id: Ie51d426de68770fad8eeb83aaab9abe8d69e84a2

Strip off the gerrit Change-Id: as it is meaningless upstream.

Thanks!
Benson

-- 
Benson Leung
Senior Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] platform: chrome: Add Tablet Switch ACPI driver Gwendal Grignou <gwendal@chromium.org> - 2017-01-24 00:50 +0100
  Re: [PATCH] platform: chrome: Add Tablet Switch ACPI driver Benson Leung <bleung@google.com> - 2017-01-28 01:40 +0100
    [PATCH v2] platform: chrome: Add Tablet Switch ACPI driver Gwendal Grignou <gwendal@chromium.org> - 2017-01-30 20:40 +0100
      Re: [PATCH v2] platform: chrome: Add Tablet Switch ACPI driver Benson Leung <bleung@chromium.org> - 2017-01-31 00:40 +0100
        [PATCH v3] platform: chrome: Add Tablet Switch ACPI driver Gwendal Grignou <gwendal@chromium.org> - 2017-01-31 00:50 +0100
          Re: [PATCH v3] platform: chrome: Add Tablet Switch ACPI driver Benson Leung <bleung@chromium.org> - 2017-02-01 19:40 +0100

csiph-web