Re: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Nicolas Ferre <nicolas.ferre@atmel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM
Date	Fri, 27 Jan 2017 11:20:02 +0100
Message-ID	<t4bNo-2Pk-7@gated-at.bofh.it> (permalink)
References	<t1kDv-1WJ-5@gated-at.bofh.it> <t3U0a-xW-21@gated-at.bofh.it> <t47A5-cB-1@gated-at.bofh.it>
X-Original-To	Harini Katakam <harinikatakamlinux@gmail.com>, Rafal Ozieblo <rafalo@cadence.com>
Organization	atmel
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1
MIME-Version	1.0
Content-Type	text/plain; charset="utf-8"
Content-Transfer-Encoding	8bit
X-Originating-IP	[10.145.133.18]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	28
X-Original-Cc	Andrei Pistirica <andrei.pistirica@microchip.com>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "davem@davemloft.net" <davem@davemloft.net>, "harini.katakam@xilinx.com" <harini.katakam@xilinx.com>, "punnaia@xilinx.com" <punnaia@xilinx.com>, "michals@xilinx.com" <michals@xilinx.com>, "anirudh@xilinx.com" <anirudh@xilinx.com>, "boris.brezillon@free-electrons.com" <boris.brezillon@free-electrons.com>, "alexandre.belloni@free-electrons.com" <alexandre.belloni@free-electrons.com>, "tbultel@pixelsurmer.com" <tbultel@pixelsurmer.com>, "richardcochran@gmail.com" <richardcochran@gmail.com>
X-Original-Date	Fri, 27 Jan 2017 11:12:24 +0100
X-Original-Message-ID	<1bf44464-6f85-64a9-a660-8d2c44015eb9@atmel.com>
X-Original-References	<1484841375-11420-1-git-send-email-andrei.pistirica@microchip.com> <BN3PR07MB25160FCBCF19918C495F43B4C9770@BN3PR07MB2516.namprd07.prod.outlook.com> <CAFcVECLuWM65zXJWtMcwijZ1ZbtH0pvKnTUR=SJagPGHEr9amg@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1568015

Show key headers only | View raw

Le 27/01/2017 à 06:42, Harini Katakam a écrit :
> Hi Rafal,
> 
> On Thu, Jan 26, 2017 at 8:45 PM, Rafal Ozieblo <rafalo@cadence.com> wrote:
>>> -----Original Message-----
>>> From: Andrei Pistirica [mailto:andrei.pistirica@microchip.com]
>>> Sent: 19 stycznia 2017 16:56
>>> Subject: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM
>>>
>>>
>>> +static inline bool gem_has_ptp(struct macb *bp)
>>> +{
>>> +     return !!(bp->caps & MACB_CAPS_GEM_HAS_PTP);
>>> +}
>> Why don't you use hardware capabilities here? Would it be better to read it from hardware instead adding it to many configuration?
> 
> If you are referring to TSU bit in DCFG5, then we will be relying on
> Cadence IP's information irrespective of the SoC capability
> and whether the PTP support was adequate.
> I think the capability approach gives better control and
> it is not really much to add.

Yes, absolutely. In fact we already had this discussion and decided that
this capability scheme was giving much more control at low cost.

Regards,
-- 
Nicolas Ferre

Thread

[PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM Andrei Pistirica <andrei.pistirica@microchip.com> - 2017-01-19 14:10 +0100
  Re: [PATCH net-next v2] macb: Common code to enable ptp support for  MACB/GEM Nicolas Ferre <nicolas.ferre@atmel.com> - 2017-01-19 17:20 +0100
    Re: [PATCH net-next v2] macb: Common code to enable ptp support for  MACB/GEM Nicolas Ferre <nicolas.ferre@atmel.com> - 2017-01-25 10:30 +0100
      Re: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM Harini Katakam <harinikatakamlinux@gmail.com> - 2017-01-25 10:40 +0100
  RE: [PATCH net-next v2] macb: Common code to enable ptp support for  MACB/GEM Rafal Ozieblo <rafalo@cadence.com> - 2017-01-26 16:20 +0100
    Re: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM Harini Katakam <harinikatakamlinux@gmail.com> - 2017-01-27 06:50 +0100
      Re: [PATCH net-next v2] macb: Common code to enable ptp support for  MACB/GEM Nicolas Ferre <nicolas.ferre@atmel.com> - 2017-01-27 11:20 +0100
      Re: [PATCH net-next v2] macb: Common code to enable ptp support for  MACB/GEM Nicolas Ferre <nicolas.ferre@atmel.com> - 2017-01-27 11:30 +0100
        RE: [PATCH net-next v2] macb: Common code to enable ptp support for  MACB/GEM Rafal Ozieblo <rafalo@cadence.com> - 2017-01-27 12:30 +0100
      RE: [PATCH net-next v2] macb: Common code to enable ptp support for  MACB/GEM Rafal Ozieblo <rafalo@cadence.com> - 2017-01-27 11:30 +0100

csiph-web