Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1568190

RE: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM

Show all headers | View raw

>-----Original Message-----
>From: Nicolas Ferre [mailto:nicolas.ferre@atmel.com] 
>Sent: 27 stycznia 2017 11:28
>Subject: Re: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM
>
>Le 27/01/2017 à 11:26, Rafal Ozieblo a écrit :
>>> -----Original Message-----
>>> From: Harini Katakam [mailto:harinikatakamlinux@gmail.com] 
>>> Sent: 27 stycznia 2017 06:43
>>> Subject: Re: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM
>>>
>>> Hi Rafal,
>>>
>>> On Thu, Jan 26, 2017 at 8:45 PM, Rafal Ozieblo <rafalo@cadence.com> wrote:
>>>>> -----Original Message-----
>>>>> From: Andrei Pistirica [mailto:andrei.pistirica@microchip.com]
>>>>> Sent: 19 stycznia 2017 16:56
>>>>> Subject: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM
>>>>>
>>>>>
>>>>> +static inline bool gem_has_ptp(struct macb *bp)
>>>>> +{
>>>>> +     return !!(bp->caps & MACB_CAPS_GEM_HAS_PTP);
>>>>> +}
>>>> Why don't you use hardware capabilities here? Would it be better to read it from hardware instead adding it to many configuration?
>>>
>>> If you are referring to TSU bit in DCFG5, then we will be relying on
>>> Cadence IP's information irrespective of the SoC capability
>>> and whether the PTP support was adequate.
>>> I think the capability approach gives better control and
>>> it is not really much to add.
>>>
>>> Regards,
>>> Harini
>>>
>> Yes, I'm referring to TSU bit.
>> What if SoC contains multiple Cadence GEMs, some with PTP support and others without?
>
>Simply define different DT compatibility strings and we're good.

What with GEM on PCI ? There is no DT.

>> Relevant will be checking both, hardware capabilities and SoC capabilities from "caps" field.
>> 
>
>
>-- 
>Nicolas Ferre
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM Andrei Pistirica <andrei.pistirica@microchip.com> - 2017-01-19 14:10 +0100
  Re: [PATCH net-next v2] macb: Common code to enable ptp support for  MACB/GEM Nicolas Ferre <nicolas.ferre@atmel.com> - 2017-01-19 17:20 +0100
    Re: [PATCH net-next v2] macb: Common code to enable ptp support for  MACB/GEM Nicolas Ferre <nicolas.ferre@atmel.com> - 2017-01-25 10:30 +0100
      Re: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM Harini Katakam <harinikatakamlinux@gmail.com> - 2017-01-25 10:40 +0100
  RE: [PATCH net-next v2] macb: Common code to enable ptp support for  MACB/GEM Rafal Ozieblo <rafalo@cadence.com> - 2017-01-26 16:20 +0100
    Re: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM Harini Katakam <harinikatakamlinux@gmail.com> - 2017-01-27 06:50 +0100
      Re: [PATCH net-next v2] macb: Common code to enable ptp support for  MACB/GEM Nicolas Ferre <nicolas.ferre@atmel.com> - 2017-01-27 11:20 +0100
      Re: [PATCH net-next v2] macb: Common code to enable ptp support for  MACB/GEM Nicolas Ferre <nicolas.ferre@atmel.com> - 2017-01-27 11:30 +0100
        RE: [PATCH net-next v2] macb: Common code to enable ptp support for  MACB/GEM Rafal Ozieblo <rafalo@cadence.com> - 2017-01-27 12:30 +0100
      RE: [PATCH net-next v2] macb: Common code to enable ptp support for  MACB/GEM Rafal Ozieblo <rafalo@cadence.com> - 2017-01-27 11:30 +0100

csiph-web