Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1567509
| From | Rafal Ozieblo <rafalo@cadence.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM |
| Date | 2017-01-26 16:20 +0100 |
| Message-ID | <t3U0a-xW-21@gated-at.bofh.it> (permalink) |
| References | <t1kDv-1WJ-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> -----Original Message-----
> From: Andrei Pistirica [mailto:andrei.pistirica@microchip.com]
> Sent: 19 stycznia 2017 16:56
> Subject: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM
>
>
> +static inline bool gem_has_ptp(struct macb *bp)
> +{
> + return !!(bp->caps & MACB_CAPS_GEM_HAS_PTP);
> +}
Why don't you use hardware capabilities here? Would it be better to read it from hardware instead adding it to many configuration?
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM Andrei Pistirica <andrei.pistirica@microchip.com> - 2017-01-19 14:10 +0100
Re: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM Nicolas Ferre <nicolas.ferre@atmel.com> - 2017-01-19 17:20 +0100
Re: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM Nicolas Ferre <nicolas.ferre@atmel.com> - 2017-01-25 10:30 +0100
Re: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM Harini Katakam <harinikatakamlinux@gmail.com> - 2017-01-25 10:40 +0100
RE: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM Rafal Ozieblo <rafalo@cadence.com> - 2017-01-26 16:20 +0100
Re: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM Harini Katakam <harinikatakamlinux@gmail.com> - 2017-01-27 06:50 +0100
Re: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM Nicolas Ferre <nicolas.ferre@atmel.com> - 2017-01-27 11:20 +0100
Re: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM Nicolas Ferre <nicolas.ferre@atmel.com> - 2017-01-27 11:30 +0100
RE: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM Rafal Ozieblo <rafalo@cadence.com> - 2017-01-27 12:30 +0100
RE: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM Rafal Ozieblo <rafalo@cadence.com> - 2017-01-27 11:30 +0100
csiph-web