[PATCH] kasan: Respect /proc/sys/kernel/traceoff_on_warning

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	[PATCH] kasan: Respect /proc/sys/kernel/traceoff_on_warning
Date	2017-01-25 15:30 +0100
Message-ID	<t3wKd-2S1-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

After much waiting I finally reproduced a KASAN issue, only to find my
trace-buffer empty of useful information because it got spooled out :/

Make kasan_report honour the /proc/sys/kernel/traceoff_on_warning
interface.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
 mm/kasan/report.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index b82b3e2..6ff7efc 100644
--- a/mm/kasan/report.c
+++ b/mm/kasan/report.c
@@ -300,6 +300,8 @@ void kasan_report(unsigned long addr, size_t size,
 	if (likely(!kasan_report_enabled()))
 		return;
 
+	disable_trace_on_warning();
+
 	info.access_addr = (void *)addr;
 	info.access_size = size;
 	info.is_write = is_write;

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] kasan: Respect /proc/sys/kernel/traceoff_on_warning Peter Zijlstra <peterz@infradead.org> - 2017-01-25 15:30 +0100
  Re: [PATCH] kasan: Respect /proc/sys/kernel/traceoff_on_warning Alexander Potapenko <glider@google.com> - 2017-01-25 15:40 +0100
  Re: [PATCH] kasan: Respect /proc/sys/kernel/traceoff_on_warning kbuild test robot <lkp@intel.com> - 2017-01-25 16:40 +0100

csiph-web