Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1566651

Re: [PATCH] kasan: Respect /proc/sys/kernel/traceoff_on_warning

Show all headers | View raw

On Wed, Jan 25, 2017 at 3:25 PM, Peter Zijlstra <peterz@infradead.org> wrote:
>
> After much waiting I finally reproduced a KASAN issue, only to find my
> trace-buffer empty of useful information because it got spooled out :/
>
> Make kasan_report honour the /proc/sys/kernel/traceoff_on_warning
> interface.
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Alexander Potapenko <glider@google.com>
> ---
>  mm/kasan/report.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/mm/kasan/report.c b/mm/kasan/report.c
> index b82b3e2..6ff7efc 100644
> --- a/mm/kasan/report.c
> +++ b/mm/kasan/report.c
> @@ -300,6 +300,8 @@ void kasan_report(unsigned long addr, size_t size,
>         if (likely(!kasan_report_enabled()))
>                 return;
>
> +       disable_trace_on_warning();
> +
>         info.access_addr = (void *)addr;
>         info.access_size = size;
>         info.is_write = is_write;



-- 
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Straße, 33
80636 München

Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] kasan: Respect /proc/sys/kernel/traceoff_on_warning Peter Zijlstra <peterz@infradead.org> - 2017-01-25 15:30 +0100
  Re: [PATCH] kasan: Respect /proc/sys/kernel/traceoff_on_warning Alexander Potapenko <glider@google.com> - 2017-01-25 15:40 +0100
  Re: [PATCH] kasan: Respect /proc/sys/kernel/traceoff_on_warning kbuild test robot <lkp@intel.com> - 2017-01-25 16:40 +0100

csiph-web