Re: [PATCH] drm/amd/powerplay: header should be defining _SMU7_CLOCK_POWER_GATING_H_

From	Alex Deucher <alexdeucher@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm/amd/powerplay: header should be defining _SMU7_CLOCK_POWER_GATING_H_
Date	2017-01-25 15:30 +0100
Message-ID	<t3wKe-2S1-23@gated-at.bofh.it> (permalink)
References	<t3uyK-1AH-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jan 25, 2017 at 7:07 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> _SMU7_CLOCK_POWER_GATING_H_ is being used as a header guard, followed by
> a #define of a different macro.  Define _SMU7_CLOCK_POWER_GATING_H_ instead
> to fix this.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks for the patch.  Nicolas beat you to it:
https://lists.freedesktop.org/archives/dri-devel/2017-January/130477.html


Alex

> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/smu7_clockpowergating.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_clockpowergating.h b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_clockpowergating.h
> index d52a28c..c96ed9e 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_clockpowergating.h
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_clockpowergating.h
> @@ -22,7 +22,7 @@
>   */
>
>  #ifndef _SMU7_CLOCK_POWER_GATING_H_
> -#define _SMU7_CLOCK__POWER_GATING_H_
> +#define _SMU7_CLOCK_POWER_GATING_H_
>
>  #include "smu7_hwmgr.h"
>  #include "pp_asicblocks.h"
> --
> 2.10.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm/amd/powerplay: header should be defining _SMU7_CLOCK_POWER_GATING_H_ Colin King <colin.king@canonical.com> - 2017-01-25 13:10 +0100
  Re: [PATCH] drm/amd/powerplay: header should be defining _SMU7_CLOCK_POWER_GATING_H_ Alex Deucher <alexdeucher@gmail.com> - 2017-01-25 15:30 +0100

csiph-web