Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1566955

Re: [PATCH 0/7] Implement generic regulator constraints parsing for ACPI and OF

Show all headers | View raw

On Wed, Jan 25, 2017 at 08:39:07PM +0000, Mark Brown wrote:
> On Wed, Jan 25, 2017 at 11:27:11AM -0800, Dmitry Torokhov wrote:
> 
> > For the record, the main issue for the drivers, which is being solved by
> > exposing power supplies to the driver, is the following:
> 
> > 1. We suspend the device. Since there is no regulators the driver
> > assumes that it will retain it's state upon resume
> 
> That's *not* a sensible thing for drivers to assume regardless of the
> presence or absence of explicitly controlled regulators, that just seems
> like a plain old driver bug.  Even if there are regulators that doesn't
> mean there isn't a suspend mode configuration that disables those
> regulators.

That means your platform description is incomplete, AKA a plain old
device tree bug.

> 
> > I would really hate to go through _every_ driver and add the following
> > code to the resume path:
> > 
> > #if IS_ENABLED(CONFIG_ACPI)
> > 	if (acpi_device_was_powered_off_between_suspend_and_now(dev)) {
> > 		completely_reinitialize_device(dev);
> > 	}
> > #endif
> 
> That's not an ACPI thing, unless the device thinks it's actively
> providing a wakeup source then if the system suspends the driver should
> not be surprised to have power pulled - that's pretty normal.  If the
> driver is a wakeup source then it's a bit different.

From the practical standpoint many drivers make this assumption because
this shortens resume time for device. I.e. it makes difference whether
we go through full controller reset, possibly reloading firmware, and
applying desired configuration, versus taking the chip out of deep sleep
mode.

The decision on resume time vs power draw is up to the platform
designers of course.

So if we indeed saying that drivers should expect handling power loss
even when devices are not on a hot-pluggable buses then we need a
generic API for querying whether device lost it's state or not.

Thanks.

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] Implement generic regulator constraints parsing for ACPI and OF Furquan Shaikh <furquan@chromium.org> - 2017-01-25 01:10 +0100
  [PATCH 6/7] drivers/gpio: Add and export gpiod_lookup[_index] Furquan Shaikh <furquan@chromium.org> - 2017-01-25 01:10 +0100
    Re: [PATCH 6/7] drivers/gpio: Add and export gpiod_lookup[_index] Linus Walleij <linus.walleij@linaro.org> - 2017-01-26 16:30 +0100
  [PATCH 7/7] drivers/regulator: Initialize regulator init data for ACPI regulators Furquan Shaikh <furquan@chromium.org> - 2017-01-25 01:10 +0100
  Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-01-25 13:30 +0100
  Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Mark Brown <broonie@kernel.org> - 2017-01-25 13:50 +0100
    Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF "Rafael J. Wysocki" <rafael@kernel.org> - 2017-01-25 14:00 +0100
      Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Furquan Shaikh <furquan@chromium.org> - 2017-01-25 18:00 +0100
        Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Mark Brown <broonie@kernel.org> - 2017-01-25 19:30 +0100
        Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Mark Rutland <mark.rutland@arm.com> - 2017-01-25 19:30 +0100
          Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Mark Brown <broonie@kernel.org> - 2017-01-25 19:40 +0100
            Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Mark Rutland <mark.rutland@arm.com> - 2017-01-25 19:40 +0100
              Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Mark Brown <broonie@kernel.org> - 2017-01-25 20:00 +0100
                Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Mark Rutland <mark.rutland@arm.com> - 2017-01-25 20:40 +0100
            Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-25 19:50 +0100
              Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-25 20:30 +0100
                Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Mark Brown <broonie@kernel.org> - 2017-01-25 21:40 +0100
                Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-25 22:20 +0100
                Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Mark Brown <broonie@kernel.org> - 2017-01-25 22:40 +0100
                Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-25 23:10 +0100
                Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Mark Brown <broonie@kernel.org> - 2017-01-25 23:30 +0100
                Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Al Stone <ahs3@redhat.com> - 2017-01-25 22:50 +0100
                Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-26 00:30 +0100
                Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Al Stone <ahs3@redhat.com> - 2017-01-26 01:20 +0100
                Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-26 01:40 +0100
                Re: [PATCH 0/7] Implement generic regulator constraints parsing for ACPI and OF "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-01-26 11:50 +0100
            Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-01-25 20:20 +0100
              Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Mark Brown <broonie@kernel.org> - 2017-01-25 21:50 +0100

csiph-web