Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1566843

Re: [PATCH 0/7] Implement generic regulator constraints parsing for ACPI and OF

Show all headers | View raw

On Wed, Jan 25, 2017 at 06:29:55PM +0000, Mark Brown wrote:
> On Wed, Jan 25, 2017 at 06:23:20PM +0000, Mark Rutland wrote:
> > On Wed, Jan 25, 2017 at 08:56:42AM -0800, Furquan Shaikh wrote:
> 
> > > That is the reason why the recent change to add ACPI support to fixed
> > > regulators was done
> > > (https://github.com/torvalds/linux/blob/master/drivers/regulator/fixed.c#L100).
> 
> > To be honest, I'm surprised this got merged.
> 
> My understanding was that it was instantiated from another device as an
> implementation detail of that device, letting it say "this GPIO should
> be handled as a regulator".
> 
> > Mark, this was added in this cycle; can we please rip that out for now?
> 
> If it's instantiated directly we probably should.
> 
> > We can certainly come up with something that allows drivers to support
> > both, but trying to do this without updating drivers opens a huge set of
> > problems.
> 
> I think there's a reasonable chance that any ACPI specs could be written
> in such a way as to allow transparent support in Linux, the main thing
> I'd worry about is naming issues.

So if I am reading this correctly, currently ACPI does not expose power
supplies directly, but rather ties them to the device power state (D0,
D3cold, etc). Linux drivers do not usually follow that state model and
expect to have all their power supplies be given to them and then
figures out what to do with them itself. Given that, what do we do? Do
we map only entries from _PR3 so they are available to drivers via
regulator_get()? Or we ask the standard to add method enumerating all
supplies?

Thanks.

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] Implement generic regulator constraints parsing for ACPI and OF Furquan Shaikh <furquan@chromium.org> - 2017-01-25 01:10 +0100
  [PATCH 6/7] drivers/gpio: Add and export gpiod_lookup[_index] Furquan Shaikh <furquan@chromium.org> - 2017-01-25 01:10 +0100
    Re: [PATCH 6/7] drivers/gpio: Add and export gpiod_lookup[_index] Linus Walleij <linus.walleij@linaro.org> - 2017-01-26 16:30 +0100
  [PATCH 7/7] drivers/regulator: Initialize regulator init data for ACPI regulators Furquan Shaikh <furquan@chromium.org> - 2017-01-25 01:10 +0100
  Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-01-25 13:30 +0100
  Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Mark Brown <broonie@kernel.org> - 2017-01-25 13:50 +0100
    Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF "Rafael J. Wysocki" <rafael@kernel.org> - 2017-01-25 14:00 +0100
      Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Furquan Shaikh <furquan@chromium.org> - 2017-01-25 18:00 +0100
        Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Mark Brown <broonie@kernel.org> - 2017-01-25 19:30 +0100
        Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Mark Rutland <mark.rutland@arm.com> - 2017-01-25 19:30 +0100
          Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Mark Brown <broonie@kernel.org> - 2017-01-25 19:40 +0100
            Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Mark Rutland <mark.rutland@arm.com> - 2017-01-25 19:40 +0100
              Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Mark Brown <broonie@kernel.org> - 2017-01-25 20:00 +0100
                Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Mark Rutland <mark.rutland@arm.com> - 2017-01-25 20:40 +0100
            Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-25 19:50 +0100
              Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-25 20:30 +0100
                Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Mark Brown <broonie@kernel.org> - 2017-01-25 21:40 +0100
                Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-25 22:20 +0100
                Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Mark Brown <broonie@kernel.org> - 2017-01-25 22:40 +0100
                Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-25 23:10 +0100
                Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Mark Brown <broonie@kernel.org> - 2017-01-25 23:30 +0100
                Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Al Stone <ahs3@redhat.com> - 2017-01-25 22:50 +0100
                Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-26 00:30 +0100
                Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Al Stone <ahs3@redhat.com> - 2017-01-26 01:20 +0100
                Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-26 01:40 +0100
                Re: [PATCH 0/7] Implement generic regulator constraints parsing for ACPI and OF "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-01-26 11:50 +0100
            Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-01-25 20:20 +0100
              Re: [PATCH 0/7] Implement generic regulator constraints parsing for  ACPI and OF Mark Brown <broonie@kernel.org> - 2017-01-25 21:50 +0100

csiph-web