Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1566943

Re: [PATCH v3] i2c: core: helper function to detect slave mode

From Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH v3] i2c: core: helper function to detect slave mode
Date 2017-01-25 22:00 +0100
Message-ID <t3CPD-6GU-3@gated-at.bofh.it> (permalink)
References <t0D5v-8eI-5@gated-at.bofh.it> <t3CFY-6Do-9@gated-at.bofh.it>
Organization Intel Finland Oy

Show all headers | View raw


On Wed, 2017-01-25 at 21:45 +0100, Wolfram Sang wrote:
> > + * i2c_slave_mode_detect - detect operation mode
> 
> I'd rather name it 'i2c_detect_slave_mode'

When I proposed that I kept in ming `git grep -n i2c_slave`.

> The code looks good to me, so we are close to go!

Thumb up!

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v3] i2c: core: helper function to detect slave mode Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-01-17 15:40 +0100
  Re: [PATCH v3] i2c: core: helper function to detect slave mode Wolfram Sang <wsa@the-dreams.de> - 2017-01-25 21:50 +0100
    Re: [PATCH v3] i2c: core: helper function to detect slave mode Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-25 22:00 +0100
      Re: [PATCH v3] i2c: core: helper function to detect slave mode Wolfram Sang <wsa@the-dreams.de> - 2017-01-25 22:10 +0100
        Re: [PATCH v3] i2c: core: helper function to detect slave mode Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-25 22:40 +0100
    Re: [PATCH v3] i2c: core: helper function to detect slave mode Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-01-26 13:00 +0100

csiph-web