Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1566938

Re: [PATCH v3] i2c: core: helper function to detect slave mode

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

> + * i2c_slave_mode_detect - detect operation mode

I'd rather name it 'i2c_detect_slave_mode'

> + * @dev:  The device owning the bus
> + *
> + * This checks the device nodes for an I2C slave by checking the address
> + * used.
> + *
> + * Returns true if an I2C slave is detected, otherwise returns false.

Both paragraphs could be a little more explicit. It is not about
"slaves" or "clients" in general, but about those entries which make the
current master act as a slave, too.

The code looks good to me, so we are close to go!

Thanks,

   Wolfram

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] i2c: core: helper function to detect slave mode Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-01-17 15:40 +0100
  Re: [PATCH v3] i2c: core: helper function to detect slave mode Wolfram Sang <wsa@the-dreams.de> - 2017-01-25 21:50 +0100
    Re: [PATCH v3] i2c: core: helper function to detect slave mode Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-25 22:00 +0100
      Re: [PATCH v3] i2c: core: helper function to detect slave mode Wolfram Sang <wsa@the-dreams.de> - 2017-01-25 22:10 +0100
        Re: [PATCH v3] i2c: core: helper function to detect slave mode Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-25 22:40 +0100
    Re: [PATCH v3] i2c: core: helper function to detect slave mode Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-01-26 13:00 +0100

csiph-web