Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1563804

Re: [PATCH 2/2] ARM: dts: exynos: Use correct mfc_pd async-bridge clock for Exynos5420

Show all headers | View raw

Hello Krzysztof,

On 01/20/2017 01:28 PM, Krzysztof Kozlowski wrote:
> On Thu, Jan 19, 2017 at 07:29:55PM -0300, Javier Martinez Canillas wrote:
>> Commit 94aed538e032 ("ARM: dts: exynos: Add async-bridge clock to MFC
>> power domain for Exynos5420") fixed an imprecise external abort error
>> when the MFC registers were tried to be accessed and the needed clock
>> for the asynchronous bridges were gated.
>>
>> But according to the Exynos5420 manual the "Gating AXI clock for MFC"
>> is not CLK_ACLK333 but CLK_MFC.
>>
>> The end effect is the same because CLK_ACLK333 is a parent of CLK_MFC
>> but the correct clock should be used instead.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>> ---
>>
>>  arch/arm/boot/dts/exynos5420.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Is this still needed?
> 

Not really, only if we care about correctness in the existing power domains
that have their clocks defined. But as said, even currently with CLK_ACLK333
works due to the clock hierarchy.

I think is less of an issue now that we prefer to mark clocks that needs to
be ungated as critical instead of growing the DT ABI.

> Best regards,
> Krzysztof
> 
 
Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] ARM: dts: exynos: Add CLK_ACLK432_SCALER clock to gsc_pd for Exynos5800 Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-19 23:50 +0100
  [PATCH 2/2] ARM: dts: exynos: Use correct mfc_pd async-bridge clock for Exynos5420 Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-19 23:50 +0100
    Re: [PATCH 2/2] ARM: dts: exynos: Use correct mfc_pd async-bridge  clock for Exynos5420 Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-20 17:30 +0100
      Re: [PATCH 2/2] ARM: dts: exynos: Use correct mfc_pd async-bridge  clock for Exynos5420 Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-20 18:20 +0100
        Re: [PATCH 2/2] ARM: dts: exynos: Use correct mfc_pd async-bridge  clock for Exynos5420 Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-20 18:40 +0100
  Re: [PATCH 1/2] ARM: dts: exynos: Add CLK_ACLK432_SCALER clock to  gsc_pd for Exynos5800 Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-20 11:30 +0100

csiph-web