Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1563749
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] ARM: dts: exynos: Use correct mfc_pd async-bridge clock for Exynos5420 |
| Date | 2017-01-20 17:30 +0100 |
| Message-ID | <t1KeC-16c-3@gated-at.bofh.it> (permalink) |
| References | <t1tGN-7wg-3@gated-at.bofh.it> <t1tGO-7wg-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jan 19, 2017 at 07:29:55PM -0300, Javier Martinez Canillas wrote:
> Commit 94aed538e032 ("ARM: dts: exynos: Add async-bridge clock to MFC
> power domain for Exynos5420") fixed an imprecise external abort error
> when the MFC registers were tried to be accessed and the needed clock
> for the asynchronous bridges were gated.
>
> But according to the Exynos5420 manual the "Gating AXI clock for MFC"
> is not CLK_ACLK333 but CLK_MFC.
>
> The end effect is the same because CLK_ACLK333 is a parent of CLK_MFC
> but the correct clock should be used instead.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> arch/arm/boot/dts/exynos5420.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Is this still needed?
Best regards,
Krzysztof
>
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index 906a1a42a7ea..ffb148ea91d6 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -294,7 +294,7 @@
> reg = <0x10044060 0x20>;
> clocks = <&clock CLK_FIN_PLL>,
> <&clock CLK_MOUT_USER_ACLK333>,
> - <&clock CLK_ACLK333>;
> + <&clock CLK_MFC>;
> clock-names = "oscclk", "clk0","asb0";
> #power-domain-cells = <0>;
> };
> --
> 2.7.4
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] ARM: dts: exynos: Add CLK_ACLK432_SCALER clock to gsc_pd for Exynos5800 Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-19 23:50 +0100
[PATCH 2/2] ARM: dts: exynos: Use correct mfc_pd async-bridge clock for Exynos5420 Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-19 23:50 +0100
Re: [PATCH 2/2] ARM: dts: exynos: Use correct mfc_pd async-bridge clock for Exynos5420 Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-20 17:30 +0100
Re: [PATCH 2/2] ARM: dts: exynos: Use correct mfc_pd async-bridge clock for Exynos5420 Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-20 18:20 +0100
Re: [PATCH 2/2] ARM: dts: exynos: Use correct mfc_pd async-bridge clock for Exynos5420 Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-20 18:40 +0100
Re: [PATCH 1/2] ARM: dts: exynos: Add CLK_ACLK432_SCALER clock to gsc_pd for Exynos5800 Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-20 11:30 +0100
csiph-web