Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1562247

Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include

Show all headers | View raw

From: David Miller <davem@davemloft.net>
Date: Wed, 18 Jan 2017 16:37:14 -0500 (EST)

> From: Russell King - ARM Linux <linux@armlinux.org.uk>
> Date: Wed, 18 Jan 2017 00:14:03 +0000
> 
>> Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an
>> unnecessary dependency for quite a large amount of the kernel.  There's
>> very little which actually requires definitions from phy.h in net/dsa.h
>> - the include itself only wants the declaration of a couple of
>> structures and IFNAMSIZ.
>> 
>> Add linux/if.h for IFNAMSIZ, declarations for the structures, phy.h to
>> mv88e6xxx.h as it needs it for phy_interface_t, and remove both phy.h
>> and phy_fixed.h from net/dsa.h.
>> 
>> This patch reduces from around 800 files rebuilt to around 40 - even
>> with ccache, the time difference is noticable.
>> 
>> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> 
> Applied, thanks.

Acutallly, I'm reverting this, it breaks the build all over the place.

The problem is that it seems that somehow we are getting an implicit
module.h include via phy.h and this propagates all over the tree.  So
I get failures like:

net/core/netprio_cgroup.c:303:16: error: expected declaration specifiers or ‘...’ before string constant
 MODULE_LICENSE("GPL v2");
 ...
net/sunrpc/xprtrdma/svc_rdma_backchannel.c: In function ‘xprt_rdma_bc_put’:
net/sunrpc/xprtrdma/svc_rdma_backchannel.c:277:2: error: implicit declaration of function ‘module_put’ [-Werror=implicit-function-declaration]
  module_put(THIS_MODULE);
  ^
net/sunrpc/xprtrdma/svc_rdma_backchannel.c: In function ‘xprt_setup_rdma_bc’:
net/sunrpc/xprtrdma/svc_rdma_backchannel.c:348:7: error: implicit declaration of function ‘try_module_get’ [-Werror=implicit-function-declaration]
  if (!try_module_get(THIS_MODULE))

Please resubmit this after you can successfully complete an allmodconfig build.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH RFC] net: dsa: remove unnecessary phy.h include Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-01-18 01:20 +0100
  Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-18 02:20 +0100
  Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include Florian Fainelli <f.fainelli@gmail.com> - 2017-01-18 02:20 +0100
  Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include David Miller <davem@davemloft.net> - 2017-01-18 22:50 +0100
    Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include David Miller <davem@davemloft.net> - 2017-01-18 23:00 +0100
    Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-01-18 23:10 +0100
    Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include David Miller <davem@davemloft.net> - 2017-01-18 23:50 +0100

csiph-web