Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1562210

Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include

Show all headers | View raw

From: Russell King - ARM Linux <linux@armlinux.org.uk>
Date: Wed, 18 Jan 2017 21:46:28 +0000

> On Wed, Jan 18, 2017 at 04:37:14PM -0500, David Miller wrote:
>> From: Russell King - ARM Linux <linux@armlinux.org.uk>
>> Date: Wed, 18 Jan 2017 00:14:03 +0000
>> 
>> > Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an
>> > unnecessary dependency for quite a large amount of the kernel.  There's
>> > very little which actually requires definitions from phy.h in net/dsa.h
>> > - the include itself only wants the declaration of a couple of
>> > structures and IFNAMSIZ.
>> > 
>> > Add linux/if.h for IFNAMSIZ, declarations for the structures, phy.h to
>> > mv88e6xxx.h as it needs it for phy_interface_t, and remove both phy.h
>> > and phy_fixed.h from net/dsa.h.
>> > 
>> > This patch reduces from around 800 files rebuilt to around 40 - even
>> > with ccache, the time difference is noticable.
>> > 
>> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
>> 
>> Applied, thanks.
> 
> Hmm, now that's _really_ interesting.

It got reviewed-by and seemed reasonable.

I am always allowed to use my judgment to turn an RFC into a patch
I actually apply, especially when other developers review the change.

If you read your email now you'll see that I reverted it before
pushing it out, because of the fallout you mention.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RFC] net: dsa: remove unnecessary phy.h include Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-01-18 01:20 +0100
  Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-18 02:20 +0100
  Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include Florian Fainelli <f.fainelli@gmail.com> - 2017-01-18 02:20 +0100
  Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include David Miller <davem@davemloft.net> - 2017-01-18 22:50 +0100
    Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include David Miller <davem@davemloft.net> - 2017-01-18 23:00 +0100
    Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-01-18 23:10 +0100
    Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include David Miller <davem@davemloft.net> - 2017-01-18 23:50 +0100

csiph-web