Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1562246

Re: [PATCH] ARM: smp: Remove CPU: shutdown notice

From Russell King - ARM Linux <linux@armlinux.org.uk>
Newsgroups linux.kernel
Subject Re: [PATCH] ARM: smp: Remove CPU: shutdown notice
Date 2017-01-18 23:50 +0100
Message-ID <t17dg-1CE-11@gated-at.bofh.it> (permalink)
References <t0L34-4Oi-27@gated-at.bofh.it> <t0Lw7-4Y5-37@gated-at.bofh.it> <t0LFL-51r-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Jan 17, 2017 at 03:39:45PM -0800, Florian Fainelli wrote:
> Well, for one it's inconsistent, and it also leaves room for subtle
> timing/caching issues with some platforms (OK, maybe not so much).
> Improving the speed and consistency was the primary motive.

Actually, it's not as inconsistent as you claim.

c68b0274fb3c ("ARM: reduce "Booted secondary processor" message to debug level")
dropped the corresponding pr_info() in the bringup path to debug level,
so to be consistent, this one should be dropped to debug level too.

Removing it arguably makes it more inconsistent!

So, I'd be willing to accept a patch lowering this to a pr_debug()
to make it more consistent with the bringup path, but otherwise the
consistency argument doesn't really stand.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] ARM: smp: Remove CPU: shutdown notice Florian Fainelli <f.fainelli@gmail.com> - 2017-01-18 00:10 +0100
  Re: [PATCH] ARM: smp: Remove CPU: shutdown notice Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-01-18 00:40 +0100
    Re: [PATCH] ARM: smp: Remove CPU: shutdown notice Florian Fainelli <f.fainelli@gmail.com> - 2017-01-18 00:50 +0100
      Re: [PATCH] ARM: smp: Remove CPU: shutdown notice Petr Mladek <pmladek@suse.com> - 2017-01-18 11:20 +0100
        Re: [PATCH] ARM: smp: Remove CPU: shutdown notice Florian Fainelli <f.fainelli@gmail.com> - 2017-01-18 21:00 +0100
          Re: [PATCH] ARM: smp: Remove CPU: shutdown notice Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-01-19 13:10 +0100
      Re: [PATCH] ARM: smp: Remove CPU: shutdown notice Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-01-18 23:50 +0100
        Re: [PATCH] ARM: smp: Remove CPU: shutdown notice Florian Fainelli <f.fainelli@gmail.com> - 2017-01-19 00:00 +0100
  [PATCH] ARM: Reduce "CPU: shutdown" message to debug level Florian Fainelli <f.fainelli@gmail.com> - 2017-01-19 00:10 +0100
    Re: [PATCH] ARM: Reduce "CPU: shutdown" message to debug level Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-01-19 00:30 +0100
      Re: [PATCH] ARM: Reduce "CPU: shutdown" message to debug level Florian Fainelli <f.fainelli@gmail.com> - 2017-01-19 01:30 +0100

csiph-web