Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1561178
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/2] [media] exynos-gsc: Fix unbalanced pm_runtime_enable() error |
| Date | 2017-01-18 01:40 +0100 |
| Message-ID | <t0Msa-5wG-11@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
Commit a006c04e6218 ("[media] exynos-gsc: Fixup clock management at
->remove()") changed the driver's .remove function logic to fist do
a pm_runtime_get_sync() to make sure the device is powered before
attempting to gate the gsc clock.
But the commit also removed a pm_runtime_disable() call that leads
to an unbalanced pm_runtime_enable() error if the driver is removed
and re-probed:
exynos-gsc 13e00000.video-scaler: Unbalanced pm_runtime_enable!
exynos-gsc 13e10000.video-scaler: Unbalanced pm_runtime_enable!
Fixes: a006c04e6218 ("[media] exynos-gsc: Fixup clock management at ->remove()")
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/media/platform/exynos-gsc/gsc-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c b/drivers/media/platform/exynos-gsc/gsc-core.c
index cbf75b6194b4..83272f10722d 100644
--- a/drivers/media/platform/exynos-gsc/gsc-core.c
+++ b/drivers/media/platform/exynos-gsc/gsc-core.c
@@ -1118,6 +1118,7 @@ static int gsc_remove(struct platform_device *pdev)
clk_disable_unprepare(gsc->clock[i]);
pm_runtime_put_noidle(&pdev->dev);
+ pm_runtime_disable(&pdev->dev);
dev_dbg(&pdev->dev, "%s driver unloaded\n", pdev->name);
return 0;
--
2.7.4
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 1/2] [media] exynos-gsc: Fix unbalanced pm_runtime_enable() error Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-18 01:40 +0100
[PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-18 01:40 +0100
Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-19 15:20 +0100
Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-19 16:00 +0100
Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-19 19:00 +0100
Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-20 09:40 +0100
Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-20 11:10 +0100
Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-20 11:50 +0100
Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-20 09:20 +0100
Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-20 11:10 +0100
Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-20 14:40 +0100
Re: [PATCH 1/2] [media] exynos-gsc: Fix unbalanced pm_runtime_enable() error Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-19 15:20 +0100
Re: [PATCH 1/2] [media] exynos-gsc: Fix unbalanced pm_runtime_enable() error Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-19 15:20 +0100
csiph-web