Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain
Date	2017-01-20 11:10 +0100
Message-ID	<t1EiS-5VC-7@gated-at.bofh.it> (permalink)
References	(2 earlier) <t0Msa-5wG-15@gated-at.bofh.it> <t1lJf-2Aj-15@gated-at.bofh.it> <t1mlY-2PW-17@gated-at.bofh.it> <t1pa9-4BO-9@gated-at.bofh.it> <t1CTM-4W3-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Marek,

On 01/20/2017 05:37 AM, Marek Szyprowski wrote:

[snip]

>>   I'll post a proper patch for the exynos5800.dtsi, to override the
>> clocks in the gsc_pd device node.
>>
>> I also see that the two power domains that fail to be disabled msc_pd
>> (power-domain@10044120) and isp_pd (power-domain@10044020) don't have
>> clocks defined in the exynos54xx.dtsi. I'll add clocks for those too.
> 
> Please send this patch instead of adding more clocks to the power domains.
> This way we will avoid adding more dependencies to userspace (DT ABI).
> Likely those clocks are also needed to access any device in that power
> domains.
> 
> Later, once the runtime PM for clocks get merged, a patch for exynos542x
> clocks driver can be made to replace IS_CRITICAL with proper runtime
> handling.
> 

Ok, I thought that we didn't want to mark more clocks as CLK_IGNORE_UNUSED
or CLK_IS_CRITICAL but I agree this can be done as a temporary workaround
until a proper runtime PM based solution gets merged.

> Best regards

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Thread

[PATCH 1/2] [media] exynos-gsc: Fix unbalanced pm_runtime_enable() error Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-18 01:40 +0100
  [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-18 01:40 +0100
    Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due  disabled power domain Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-19 15:20 +0100
      Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due  disabled power domain Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-19 16:00 +0100
        Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due  disabled power domain Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-19 19:00 +0100
          Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due  disabled power domain Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-20 09:40 +0100
            Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due  disabled power domain Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-20 11:10 +0100
              Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due  disabled power domain Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-20 11:50 +0100
        Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due  disabled power domain Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-20 09:20 +0100
          Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due  disabled power domain Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-20 11:10 +0100
          Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due  disabled power domain Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-20 14:40 +0100
  Re: [PATCH 1/2] [media] exynos-gsc: Fix unbalanced  pm_runtime_enable() error Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-19 15:20 +0100
  Re: [PATCH 1/2] [media] exynos-gsc: Fix unbalanced pm_runtime_enable()  error Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-19 15:20 +0100

csiph-web