Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1561166
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name() |
| Date | 2017-01-18 01:20 +0100 |
| Message-ID | <t0M8O-5qs-3@gated-at.bofh.it> (permalink) |
| References | (2 earlier) <t0Lw7-4Y5-35@gated-at.bofh.it> <t0LPs-54F-11@gated-at.bofh.it> <t0LZ8-5nf-51@gated-at.bofh.it> <t0LZ8-5nf-53@gated-at.bofh.it> <t0LZ8-5nf-49@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 01/17/2017 04:07 PM, Andy Shevchenko wrote: > On Wed, Jan 18, 2017 at 2:04 AM, Florian Fainelli <f.fainelli@gmail.com> wrote: >> On 01/17/2017 04:00 PM, Andy Shevchenko wrote: >>> On Wed, Jan 18, 2017 at 1:43 AM, Florian Fainelli <f.fainelli@gmail.com> wrote: >>>> On 01/17/2017 03:34 PM, Andy Shevchenko wrote: >>>>> On Wed, Jan 18, 2017 at 1:21 AM, Florian Fainelli <f.fainelli@gmail.com> wrote: > >>> But why not to use void *class_name to be consistent with callback and >>> device_find_child()? >> >> The top-level function: device_find_in_class_name() should have a >> stronger typing of its argument even if it internally uses >> device_find_child() and a callback that takes a void * argument, that's >> how I see it. > > Fair enough. > >>> Btw, >>> return get_device(parent); >> >> Not sure I follow what that means here? > > Missed remark. Instead of > > get_device(parent); > return parent; > > you can use > > return get_device(parent); Seems reasonable, if I have to respin a v5, will add that, thanks! -- Florian
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name() Florian Fainelli <f.fainelli@gmail.com> - 2017-01-18 00:30 +0100
Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-18 00:40 +0100
Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name() Florian Fainelli <f.fainelli@gmail.com> - 2017-01-18 01:00 +0100
Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-18 01:10 +0100
Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name() Florian Fainelli <f.fainelli@gmail.com> - 2017-01-18 01:20 +0100
Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-18 01:10 +0100
Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name() Florian Fainelli <f.fainelli@gmail.com> - 2017-01-18 01:10 +0100
Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-18 08:20 +0100
csiph-web