Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1561163

Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()

From Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()
Date 2017-01-18 01:10 +0100
Message-ID <t0LZ8-5nf-51@gated-at.bofh.it> (permalink)
References <t0Lmp-4UR-7@gated-at.bofh.it> <t0Lmp-4UR-5@gated-at.bofh.it> <t0Lw7-4Y5-35@gated-at.bofh.it> <t0LPs-54F-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, Jan 18, 2017 at 1:43 AM, Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 01/17/2017 03:34 PM, Andy Shevchenko wrote:
>> On Wed, Jan 18, 2017 at 1:21 AM, Florian Fainelli <f.fainelli@gmail.com> wrote:

>>> +static int device_class_name_match(struct device *dev, void *class)
>>
>> And why not const char *class?
>
> This was raised back in v2, and the same response applies:
>
> https://www.mail-archive.com/netdev@vger.kernel.org/msg147559.html
>
> Changing the signature of a callback is out of the scope of this patch
> series.

Ah, right.

But why not to use void *class_name to be consistent with callback and
device_find_child()?

Btw,

return get_device(parent);

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name() Florian Fainelli <f.fainelli@gmail.com> - 2017-01-18 00:30 +0100
  Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-18 00:40 +0100
    Re: [PATCH net-next v4 05/10] drivers: base: Add  device_find_in_class_name() Florian Fainelli <f.fainelli@gmail.com> - 2017-01-18 01:00 +0100
      Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-18 01:10 +0100
        Re: [PATCH net-next v4 05/10] drivers: base: Add  device_find_in_class_name() Florian Fainelli <f.fainelli@gmail.com> - 2017-01-18 01:20 +0100
      Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-18 01:10 +0100
        Re: [PATCH net-next v4 05/10] drivers: base: Add  device_find_in_class_name() Florian Fainelli <f.fainelli@gmail.com> - 2017-01-18 01:10 +0100
  Re: [PATCH net-next v4 05/10] drivers: base: Add  device_find_in_class_name() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-18 08:20 +0100

csiph-web