Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1514849
| From | Matt Fleming <matt@codeblueprint.co.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] x86/boot: Remove always empty $(USERINCLUDE) |
| Date | 2016-11-03 22:30 +0100 |
| Message-ID | <szxK9-Rd-23@gated-at.bofh.it> (permalink) |
| References | <szmOJ-261-13@gated-at.bofh.it> <szmYp-29e-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, 03 Nov, at 10:51:38AM, Paul Bolle wrote:
> Apparently Matt left Intel. Let's forward this to a recently used
> address.
>
> On Thu, 2016-11-03 at 10:47 +0100, Paul Bolle wrote:
> > Commmit b6eea87fc685 ("x86, boot: Explicitly include autoconf.h for
> > hostprogs") correctly noted
> > [...] that because $(USERINCLUDE) isn't exported by
> > the top-level Makefile it's actually empty in arch/x86/boot/Makefile.
> >
> > So let's do the sane thing and remove the reference to that make variable.
> >
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > ---
> > arch/x86/boot/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
> > index 12ea8f8384f4..0d810fb15eac 100644
> > --- a/arch/x86/boot/Makefile
> > +++ b/arch/x86/boot/Makefile
> > @@ -65,7 +65,7 @@ clean-files += cpustr.h
> >
> > # ---------------------------------------------------------------------------
> >
> > -KBUILD_CFLAGS := $(USERINCLUDE) $(REALMODE_CFLAGS) -D_SETUP
> > +KBUILD_CFLAGS := $(REALMODE_CFLAGS) -D_SETUP
> > KBUILD_AFLAGS := $(KBUILD_CFLAGS) -D__ASSEMBLY__
> > GCOV_PROFILE := n
> > UBSAN_SANITIZE := n
Looks OK to me.
Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] x86/boot: Remove always empty $(USERINCLUDE) Paul Bolle <pebolle@tiscali.nl> - 2016-11-03 10:50 +0100
Re: [PATCH] x86/boot: Remove always empty $(USERINCLUDE) Paul Bolle <pebolle@tiscali.nl> - 2016-11-03 11:00 +0100
Re: [PATCH] x86/boot: Remove always empty $(USERINCLUDE) Matt Fleming <matt@codeblueprint.co.uk> - 2016-11-03 22:30 +0100
[tip:x86/boot] x86/boot/build: Remove always empty $(USERINCLUDE) tip-bot for Paul Bolle <tipbot@zytor.com> - 2016-11-07 10:00 +0100
csiph-web