Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1514418 > unrolled thread

[PATCH] x86/boot: Remove always empty $(USERINCLUDE)

Started byPaul Bolle <pebolle@tiscali.nl>
First post2016-11-03 10:50 +0100
Last post2016-11-07 10:00 +0100
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] x86/boot: Remove always empty $(USERINCLUDE) Paul Bolle <pebolle@tiscali.nl> - 2016-11-03 10:50 +0100
    Re: [PATCH] x86/boot: Remove always empty $(USERINCLUDE) Paul Bolle <pebolle@tiscali.nl> - 2016-11-03 11:00 +0100
      Re: [PATCH] x86/boot: Remove always empty $(USERINCLUDE) Matt Fleming <matt@codeblueprint.co.uk> - 2016-11-03 22:30 +0100
    [tip:x86/boot] x86/boot/build: Remove always empty $(USERINCLUDE) tip-bot for Paul Bolle <tipbot@zytor.com> - 2016-11-07 10:00 +0100

#1514418 — [PATCH] x86/boot: Remove always empty $(USERINCLUDE)

FromPaul Bolle <pebolle@tiscali.nl>
Date2016-11-03 10:50 +0100
Subject[PATCH] x86/boot: Remove always empty $(USERINCLUDE)
Message-ID<szmOJ-261-13@gated-at.bofh.it>
Commmit b6eea87fc685 ("x86, boot: Explicitly include autoconf.h for
hostprogs") correctly noted
    [...] that because $(USERINCLUDE) isn't exported by
    the top-level Makefile it's actually empty in arch/x86/boot/Makefile.

So let's do the sane thing and remove the reference to that make variable.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
 arch/x86/boot/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
index 12ea8f8384f4..0d810fb15eac 100644
--- a/arch/x86/boot/Makefile
+++ b/arch/x86/boot/Makefile
@@ -65,7 +65,7 @@ clean-files += cpustr.h
 
 # ---------------------------------------------------------------------------
 
-KBUILD_CFLAGS	:= $(USERINCLUDE) $(REALMODE_CFLAGS) -D_SETUP
+KBUILD_CFLAGS	:= $(REALMODE_CFLAGS) -D_SETUP
 KBUILD_AFLAGS	:= $(KBUILD_CFLAGS) -D__ASSEMBLY__
 GCOV_PROFILE := n
 UBSAN_SANITIZE := n
-- 
2.7.4

[toc] | [next] | [standalone]

#1514421

FromPaul Bolle <pebolle@tiscali.nl>
Date2016-11-03 11:00 +0100
Message-ID<szmYp-29e-7@gated-at.bofh.it>
In reply to#1514418
Apparently Matt left Intel. Let's forward this to a recently used
address.

On Thu, 2016-11-03 at 10:47 +0100, Paul Bolle wrote:
> Commmit b6eea87fc685 ("x86, boot: Explicitly include autoconf.h for
> hostprogs") correctly noted
>     [...] that because $(USERINCLUDE) isn't exported by
>     the top-level Makefile it's actually empty in arch/x86/boot/Makefile.
> 
> So let's do the sane thing and remove the reference to that make variable.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
>  arch/x86/boot/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
> index 12ea8f8384f4..0d810fb15eac 100644
> --- a/arch/x86/boot/Makefile
> +++ b/arch/x86/boot/Makefile
> @@ -65,7 +65,7 @@ clean-files += cpustr.h
>  
>  # ---------------------------------------------------------------------------
>  
> -KBUILD_CFLAGS	:= $(USERINCLUDE) $(REALMODE_CFLAGS) -D_SETUP
> +KBUILD_CFLAGS	:= $(REALMODE_CFLAGS) -D_SETUP
>  KBUILD_AFLAGS	:= $(KBUILD_CFLAGS) -D__ASSEMBLY__
>  GCOV_PROFILE := n
>  UBSAN_SANITIZE := n

[toc] | [prev] | [next] | [standalone]

#1514849

FromMatt Fleming <matt@codeblueprint.co.uk>
Date2016-11-03 22:30 +0100
Message-ID<szxK9-Rd-23@gated-at.bofh.it>
In reply to#1514421
On Thu, 03 Nov, at 10:51:38AM, Paul Bolle wrote:
> Apparently Matt left Intel. Let's forward this to a recently used
> address.
> 
> On Thu, 2016-11-03 at 10:47 +0100, Paul Bolle wrote:
> > Commmit b6eea87fc685 ("x86, boot: Explicitly include autoconf.h for
> > hostprogs") correctly noted
> >     [...] that because $(USERINCLUDE) isn't exported by
> >     the top-level Makefile it's actually empty in arch/x86/boot/Makefile.
> > 
> > So let's do the sane thing and remove the reference to that make variable.
> > 
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > ---
> >  arch/x86/boot/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
> > index 12ea8f8384f4..0d810fb15eac 100644
> > --- a/arch/x86/boot/Makefile
> > +++ b/arch/x86/boot/Makefile
> > @@ -65,7 +65,7 @@ clean-files += cpustr.h
> >  
> >  # ---------------------------------------------------------------------------
> >  
> > -KBUILD_CFLAGS	:= $(USERINCLUDE) $(REALMODE_CFLAGS) -D_SETUP
> > +KBUILD_CFLAGS	:= $(REALMODE_CFLAGS) -D_SETUP
> >  KBUILD_AFLAGS	:= $(KBUILD_CFLAGS) -D__ASSEMBLY__
> >  GCOV_PROFILE := n
> >  UBSAN_SANITIZE := n

Looks OK to me.

Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>

[toc] | [prev] | [next] | [standalone]

#1515915 — [tip:x86/boot] x86/boot/build: Remove always empty $(USERINCLUDE)

Fromtip-bot for Paul Bolle <tipbot@zytor.com>
Date2016-11-07 10:00 +0100
Subject[tip:x86/boot] x86/boot/build: Remove always empty $(USERINCLUDE)
Message-ID<sANWx-zK-5@gated-at.bofh.it>
In reply to#1514418
Commit-ID:  0acba3f91823a5e53a54af5dc31fc774b0e64e99
Gitweb:     http://git.kernel.org/tip/0acba3f91823a5e53a54af5dc31fc774b0e64e99
Author:     Paul Bolle <pebolle@tiscali.nl>
AuthorDate: Thu, 3 Nov 2016 10:47:48 +0100
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 7 Nov 2016 07:30:01 +0100

x86/boot/build: Remove always empty $(USERINCLUDE)

Commmit b6eea87fc685:

  ("x86, boot: Explicitly include autoconf.h for hostprogs")

correctly noted:

    [...] that because $(USERINCLUDE) isn't exported by
    the top-level Makefile it's actually empty in arch/x86/boot/Makefile.

So let's do the sane thing and remove the reference to that make variable.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>
Cc: David Howells <dhowells@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1478166468-9760-1-git-send-email-pebolle@tiscali.nl
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/boot/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
index 12ea8f8..0d810fb 100644
--- a/arch/x86/boot/Makefile
+++ b/arch/x86/boot/Makefile
@@ -65,7 +65,7 @@ clean-files += cpustr.h
 
 # ---------------------------------------------------------------------------
 
-KBUILD_CFLAGS	:= $(USERINCLUDE) $(REALMODE_CFLAGS) -D_SETUP
+KBUILD_CFLAGS	:= $(REALMODE_CFLAGS) -D_SETUP
 KBUILD_AFLAGS	:= $(KBUILD_CFLAGS) -D__ASSEMBLY__
 GCOV_PROFILE := n
 UBSAN_SANITIZE := n

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web