Path: csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.unit0.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: Matt Fleming Newsgroups: linux.kernel Subject: Re: [PATCH] x86/boot: Remove always empty $(USERINCLUDE) Date: Thu, 03 Nov 2016 22:30:01 +0100 Message-ID: References: Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeblueprint-co-uk.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=XvxMZPPFwPbwshRcifqMTmIObi+P6XNGXcfrVtP5cNo=; b=vgdf/EttrwDCxiV75Qe97MBZ7Q3gjv5vKU7ksU3Z/TC6mO1qM4hOH+/p/gNBEynhwn UthXl8iL9MOTq90T6Mfv/P+YdePcr6uDaD8FPTXicfiP3McJdR/3BBYN62FB8RlWbw/n TVbKHpLTwnFiUsj3RkbUjBcoiQWlZC1AQEXbqMUhK/RwN/bxhG5iF0GXw8UA5lx/Sshz gKPULMJmuooeFPLco1ywNJQ/OWG1K9mmoAN7bNl2Uj6yftKzQJXjqW7AZ+KZcqZsYHgO VoIMhB+VZQRfodMmzZNBBSMJStBrkcB8Qubsn6n4NeNKs9emeS3Mx9/DFr9Y14qGLO2f mn5w== X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=XvxMZPPFwPbwshRcifqMTmIObi+P6XNGXcfrVtP5cNo=; b=Xk/cnawnEwju9DfQFtM/MdMJkJD9uAilz+SuRqUAWJgwz99F6g9H4iGOhz1DpXof1K AGZavzxVC9zy7H2cmYg5AKGVZtCI0qMp4fogci+kzwCm+Ahj09HAZhvl9c7DVBFyX+Kg Wbb5fV2Ihoeqmx9oD6NwhDrJZv3bjpS2bW2xo4c9lEzcsv/eHjWTJLjptCrNwWRg/j+R I7Tz8vRsOGi/cjewP4wN0/+jBlRX5yY4L2K8mI28BgO7vdfmXkuH7McVwTBhrwQKblJS ayiWg3IgfUsOo2VnWUuW1UbaLX1bt36B5l0Ng6XDjKXgoayhTdXCtqpI24L6Vct0DvjB qRhQ== X-Gm-Message-State: ABUngvd0vpwOa0zlcEb8isAPlYFEFvfxgBRe22rSOHLDkJT/i5We0DFdPjqLE23DEqM7IA== X-Received: by 10.194.7.68 with SMTP id h4mr9054191wja.156.1478208408227; Thu, 03 Nov 2016 14:26:48 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 34 Organization: linux.* mail to news gateway X-Original-Cc: "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , David Howells , x86@kernel.org, linux-kernel@vger.kernel.org X-Original-Date: Thu, 3 Nov 2016 21:26:46 +0000 X-Original-Message-ID: <20161103212646.GB8845@codeblueprint.co.uk> X-Original-References: <1478166468-9760-1-git-send-email-pebolle@tiscali.nl> <1478166698.8359.4.camel@tiscali.nl> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1514849 On Thu, 03 Nov, at 10:51:38AM, Paul Bolle wrote: > Apparently Matt left Intel. Let's forward this to a recently used > address. > > On Thu, 2016-11-03 at 10:47 +0100, Paul Bolle wrote: > > Commmit b6eea87fc685 ("x86, boot: Explicitly include autoconf.h for > > hostprogs") correctly noted > >     [...] that because $(USERINCLUDE) isn't exported by > >     the top-level Makefile it's actually empty in arch/x86/boot/Makefile. > > > > So let's do the sane thing and remove the reference to that make variable. > > > > Signed-off-by: Paul Bolle > > --- > >  arch/x86/boot/Makefile | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile > > index 12ea8f8384f4..0d810fb15eac 100644 > > --- a/arch/x86/boot/Makefile > > +++ b/arch/x86/boot/Makefile > > @@ -65,7 +65,7 @@ clean-files += cpustr.h > >   > >  # --------------------------------------------------------------------------- > >   > > -KBUILD_CFLAGS := $(USERINCLUDE) $(REALMODE_CFLAGS) -D_SETUP > > +KBUILD_CFLAGS := $(REALMODE_CFLAGS) -D_SETUP > >  KBUILD_AFLAGS := $(KBUILD_CFLAGS) -D__ASSEMBLY__ > >  GCOV_PROFILE := n > >  UBSAN_SANITIZE := n Looks OK to me. Reviewed-by: Matt Fleming