Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1514793
| Path | csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Krzysztof Kozlowski <krzk@kernel.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 2/5] pinctrl: samsung: Add GPF support for Exynos5433 |
| Date | Thu, 03 Nov 2016 20:30:02 +0100 |
| Message-ID | <szvS2-87f-23@gated-at.bofh.it> (permalink) |
| References | <szjQS-iS-1@gated-at.bofh.it> <szk0y-mc-7@gated-at.bofh.it> |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EdkT6lyE4ad9UFoP69ZgLZxz770IAJK3Oc5orIiz4hk=; b=O0cxOtljgEZLlkqRIugjnW82MFhP/m5OOJnTXZ6M5RYOq2I9Z6cFiVRHLuGnpbJmCv 492vDI6Ov8SIGP4NK2uYPy12ptslAS7hbi3ea6gls4NLu7tS++86HnkwG50NXjFJ6XWo g0IRxNUVbod0W6+KKXBj9b325m6XopP3z/7l9CkDbnZWD3fVyNO+YU+KqIk6o87HgfuQ 3vsx9Mpt5EL4neldav+Vz74e3cZ9ntsrVx8AVfWvfu3UT+jmIMlC5vQYRLA4mHrcBmQK xnGf7/0oHkjzrkcAaRL4D+2/rX2VLQin79C6z3kiocRSC8nUNuc+V7Wm8RKyZScShe0z cxCA== |
| X-Gm-Message-State | ABUngvd71YSeiTwjDGkEFSJK7j103WriA9BOLocRbppI65WOTHdpGPLUui3GLrP9e5A+Ow== |
| X-Received | by 10.28.113.218 with SMTP id d87mr9417808wmi.111.1478200809218; Thu, 03 Nov 2016 12:20:09 -0700 (PDT) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=utf-8 |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.24 (2015-08-30) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 55 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | krzk@kernel.org, kgene@kernel.org, javier@osg.samsung.com, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, jh80.chung@samsung.com, sw0312.kim@samsung.com, jy0922.shim@samsung.com, inki.dae@samsung.com, jonghwa3.lee@samsung.com, beomho.seo@samsung.com, jaewon02.kim@samsung.com, human.hwang@samsung.com, ideal.song@samsung.com, ingi2.kim@samsung.com, m.szyprowski@samsung.com, a.hajda@samsung.com, s.nawrocki@samsung.com, andi.shyti@samsung.com, chanwoo@kernel.org, Tomasz Figa <tomasz.figa@gmail.com>, Linus Walleij <linus.walleij@linaro.org>, linux-gpio@vger.kernel.org |
| X-Original-Date | Thu, 3 Nov 2016 21:20:02 +0200 |
| X-Original-Message-ID | <20161103192002.GB12945@kozik-lap> |
| X-Original-References | <1478155149-28527-1-git-send-email-cw00.choi@samsung.com> <1478155149-28527-3-git-send-email-cw00.choi@samsung.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1514793 |
Show key headers only | View raw
On Thu, Nov 03, 2016 at 03:39:06PM +0900, Chanwoo Choi wrote:
> This patch add the support of GPF[1-5] pin of Exynos5433 SoC. The GPFx need
> to support the multiple memory map because the registers of GPFx are located
> in the different domain.
>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> drivers/pinctrl/samsung/pinctrl-exynos.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
I think that, instead of in previous patch, the
"samsung,exynos5433-pinctrl" compatible should be documented here along
with information that it requires two addresses for mappings.
Best regards,
Krzysztof
> diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c
> index d657b52dfdb5..12f7d1eb65bc 100644
> --- a/drivers/pinctrl/samsung/pinctrl-exynos.c
> +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c
> @@ -1339,6 +1339,11 @@ static void exynos_pinctrl_resume(struct samsung_pinctrl_drv_data *drvdata)
> EXYNOS_PIN_BANK_EINTW(8, 0x020, "gpa1", 0x04),
> EXYNOS_PIN_BANK_EINTW(8, 0x040, "gpa2", 0x08),
> EXYNOS_PIN_BANK_EINTW(8, 0x060, "gpa3", 0x0c),
> + EXYNOS_PIN_BANK_EINTW_EXT(8, 0x020, "gpf1", 0x1004, 1),
> + EXYNOS_PIN_BANK_EINTW_EXT(4, 0x040, "gpf2", 0x1008, 1),
> + EXYNOS_PIN_BANK_EINTW_EXT(4, 0x060, "gpf3", 0x100c, 1),
> + EXYNOS_PIN_BANK_EINTW_EXT(8, 0x080, "gpf4", 0x1010, 1),
> + EXYNOS_PIN_BANK_EINTW_EXT(8, 0x0a0, "gpf5", 0x1014, 1),
> };
>
> /* pin banks of exynos5433 pin-controller - AUD */
> @@ -1420,6 +1425,7 @@ static void exynos_pinctrl_resume(struct samsung_pinctrl_drv_data *drvdata)
> .eint_wkup_init = exynos_eint_wkup_init,
> .suspend = exynos_pinctrl_suspend,
> .resume = exynos_pinctrl_resume,
> + .nr_ext_resources = 1,
> }, {
> /* pin-controller instance 1 data */
> .pin_banks = exynos5433_pin_banks1,
> --
> 1.9.1
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 0/5] arm64: dts: Add the dts file for Exynos5433 and TM/TM2E board Chanwoo Choi <cw00.choi@samsung.com> - 2016-11-03 07:40 +0100
[PATCH v3 5/5] arm64: dts: exynos: Add dts file for Exynos5433-based TM2E board Chanwoo Choi <cw00.choi@samsung.com> - 2016-11-03 07:40 +0100
Re: [PATCH v3 5/5] arm64: dts: exynos: Add dts file for Exynos5433-based TM2E board Andi Shyti <andi.shyti@samsung.com> - 2016-11-03 13:30 +0100
Re: [PATCH v3 5/5] arm64: dts: exynos: Add dts file for Exynos5433-based TM2E board Krzysztof Kozlowski <krzk@kernel.org> - 2016-11-03 21:20 +0100
[PATCH v3 4/5] arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board Chanwoo Choi <cw00.choi@samsung.com> - 2016-11-03 07:40 +0100
Re: [PATCH v3 4/5] arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board Andi Shyti <andi.shyti@samsung.com> - 2016-11-03 13:30 +0100
Re: [PATCH v3 4/5] arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board Krzysztof Kozlowski <krzk@kernel.org> - 2016-11-03 21:20 +0100
[PATCH v3 1/5] pinctrl: samsung: Add the support the multiple IORESOURCE_MEM for one pin-bank Chanwoo Choi <cw00.choi@samsung.com> - 2016-11-03 07:50 +0100
Re: [PATCH v3 1/5] pinctrl: samsung: Add the support the multiple IORESOURCE_MEM for one pin-bank Krzysztof Kozlowski <krzk@kernel.org> - 2016-11-03 20:20 +0100
Re: [PATCH v3 1/5] pinctrl: samsung: Add the support the multiple IORESOURCE_MEM for one pin-bank Linus Walleij <linus.walleij@linaro.org> - 2016-11-08 10:40 +0100
[PATCH v3 2/5] pinctrl: samsung: Add GPF support for Exynos5433 Chanwoo Choi <cw00.choi@samsung.com> - 2016-11-03 07:50 +0100
Re: [PATCH v3 2/5] pinctrl: samsung: Add GPF support for Exynos5433 Krzysztof Kozlowski <krzk@kernel.org> - 2016-11-03 20:30 +0100
Re: [PATCH v3 2/5] pinctrl: samsung: Add GPF support for Exynos5433 Linus Walleij <linus.walleij@linaro.org> - 2016-11-08 10:40 +0100
Re: [PATCH v3 2/5] pinctrl: samsung: Add GPF support for Exynos5433 Linus Walleij <linus.walleij@linaro.org> - 2016-11-08 10:40 +0100
Re: [PATCH v3 3/5] arm64: dts: exynos: Add dts files for Samsung Exynos5433 64bit SoC Krzysztof Kozlowski <krzk@kernel.org> - 2016-11-03 20:50 +0100
Re: [PATCH v3 3/5] arm64: dts: exynos: Add dts files for Samsung Exynos5433 64bit SoC Krzysztof Kozlowski <krzk@kernel.org> - 2016-11-03 21:20 +0100
csiph-web