Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1514793

Re: [PATCH v3 2/5] pinctrl: samsung: Add GPF support for Exynos5433

Show all headers | View raw

On Thu, Nov 03, 2016 at 03:39:06PM +0900, Chanwoo Choi wrote:
> This patch add the support of GPF[1-5] pin of Exynos5433 SoC. The GPFx need
> to support the multiple memory map because the registers of GPFx are located
> in the different domain.
> 
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  drivers/pinctrl/samsung/pinctrl-exynos.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

I think that, instead of in previous patch, the
"samsung,exynos5433-pinctrl" compatible should be documented here along
with information that it requires two addresses for mappings.

Best regards,
Krzysztof


> diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c
> index d657b52dfdb5..12f7d1eb65bc 100644
> --- a/drivers/pinctrl/samsung/pinctrl-exynos.c
> +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c
> @@ -1339,6 +1339,11 @@ static void exynos_pinctrl_resume(struct samsung_pinctrl_drv_data *drvdata)
>  	EXYNOS_PIN_BANK_EINTW(8, 0x020, "gpa1", 0x04),
>  	EXYNOS_PIN_BANK_EINTW(8, 0x040, "gpa2", 0x08),
>  	EXYNOS_PIN_BANK_EINTW(8, 0x060, "gpa3", 0x0c),
> +	EXYNOS_PIN_BANK_EINTW_EXT(8, 0x020, "gpf1", 0x1004, 1),
> +	EXYNOS_PIN_BANK_EINTW_EXT(4, 0x040, "gpf2", 0x1008, 1),
> +	EXYNOS_PIN_BANK_EINTW_EXT(4, 0x060, "gpf3", 0x100c, 1),
> +	EXYNOS_PIN_BANK_EINTW_EXT(8, 0x080, "gpf4", 0x1010, 1),
> +	EXYNOS_PIN_BANK_EINTW_EXT(8, 0x0a0, "gpf5", 0x1014, 1),
>  };
>  
>  /* pin banks of exynos5433 pin-controller - AUD */
> @@ -1420,6 +1425,7 @@ static void exynos_pinctrl_resume(struct samsung_pinctrl_drv_data *drvdata)
>  		.eint_wkup_init = exynos_eint_wkup_init,
>  		.suspend	= exynos_pinctrl_suspend,
>  		.resume		= exynos_pinctrl_resume,
> +		.nr_ext_resources = 1,
>  	}, {
>  		/* pin-controller instance 1 data */
>  		.pin_banks	= exynos5433_pin_banks1,
> -- 
> 1.9.1
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/5] arm64: dts: Add the dts file for Exynos5433 and TM/TM2E  board Chanwoo Choi <cw00.choi@samsung.com> - 2016-11-03 07:40 +0100
  [PATCH v3 5/5] arm64: dts: exynos: Add dts file for Exynos5433-based  TM2E board Chanwoo Choi <cw00.choi@samsung.com> - 2016-11-03 07:40 +0100
    Re: [PATCH v3 5/5] arm64: dts: exynos: Add dts file for  Exynos5433-based TM2E board Andi Shyti <andi.shyti@samsung.com> - 2016-11-03 13:30 +0100
    Re: [PATCH v3 5/5] arm64: dts: exynos: Add dts file for  Exynos5433-based TM2E board Krzysztof Kozlowski <krzk@kernel.org> - 2016-11-03 21:20 +0100
  [PATCH v3 4/5] arm64: dts: exynos: Add dts file for Exynos5433-based  TM2 board Chanwoo Choi <cw00.choi@samsung.com> - 2016-11-03 07:40 +0100
    Re: [PATCH v3 4/5] arm64: dts: exynos: Add dts file for  Exynos5433-based TM2 board Andi Shyti <andi.shyti@samsung.com> - 2016-11-03 13:30 +0100
    Re: [PATCH v3 4/5] arm64: dts: exynos: Add dts file for  Exynos5433-based TM2 board Krzysztof Kozlowski <krzk@kernel.org> - 2016-11-03 21:20 +0100
  [PATCH v3 1/5] pinctrl: samsung: Add the support the multiple  IORESOURCE_MEM for one pin-bank Chanwoo Choi <cw00.choi@samsung.com> - 2016-11-03 07:50 +0100
    Re: [PATCH v3 1/5] pinctrl: samsung: Add the support the multiple  IORESOURCE_MEM for one pin-bank Krzysztof Kozlowski <krzk@kernel.org> - 2016-11-03 20:20 +0100
    Re: [PATCH v3 1/5] pinctrl: samsung: Add the support the multiple  IORESOURCE_MEM for one pin-bank Linus Walleij <linus.walleij@linaro.org> - 2016-11-08 10:40 +0100
  [PATCH v3 2/5] pinctrl: samsung: Add GPF support for Exynos5433 Chanwoo Choi <cw00.choi@samsung.com> - 2016-11-03 07:50 +0100
    Re: [PATCH v3 2/5] pinctrl: samsung: Add GPF support for Exynos5433 Krzysztof Kozlowski <krzk@kernel.org> - 2016-11-03 20:30 +0100
      Re: [PATCH v3 2/5] pinctrl: samsung: Add GPF support for Exynos5433 Linus Walleij <linus.walleij@linaro.org> - 2016-11-08 10:40 +0100
    Re: [PATCH v3 2/5] pinctrl: samsung: Add GPF support for Exynos5433 Linus Walleij <linus.walleij@linaro.org> - 2016-11-08 10:40 +0100
  Re: [PATCH v3 3/5] arm64: dts: exynos: Add dts files for Samsung  Exynos5433 64bit SoC Krzysztof Kozlowski <krzk@kernel.org> - 2016-11-03 20:50 +0100
    Re: [PATCH v3 3/5] arm64: dts: exynos: Add dts files for Samsung  Exynos5433 64bit SoC Krzysztof Kozlowski <krzk@kernel.org> - 2016-11-03 21:20 +0100

csiph-web