Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1515239
| From | Sebastian Frias <sf84@laposte.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level |
| Date | 2016-11-04 16:10 +0100 |
| Message-ID | <szOhX-3pW-7@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
The delay can be applied at PHY or MAC level, but since PHY drivers will apply the delay at PHY level when using one of the "internal delay" declinations of RGMII mode (like PHY_INTERFACE_MODE_RGMII_TXID), applying it again at MAC level causes issues. Signed-off-by: Sebastian Frias <sf84@laposte.net> --- drivers/net/ethernet/aurora/nb8800.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c index b59aa35..d2855c9 100644 --- a/drivers/net/ethernet/aurora/nb8800.c +++ b/drivers/net/ethernet/aurora/nb8800.c @@ -1282,7 +1282,7 @@ static int nb8800_tangox_init(struct net_device *dev) break; case PHY_INTERFACE_MODE_RGMII_TXID: - pad_mode = PAD_MODE_RGMII | PAD_MODE_GTX_CLK_DELAY; + pad_mode = PAD_MODE_RGMII; break; default: -- 1.7.11.2
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level Sebastian Frias <sf84@laposte.net> - 2016-11-04 16:10 +0100
Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level Måns Rullgård <mans@mansr.com> - 2016-11-04 16:20 +0100
Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level Sebastian Frias <sf84@laposte.net> - 2016-11-04 16:40 +0100
Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level Florian Fainelli <f.fainelli@gmail.com> - 2016-11-04 17:30 +0100
Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level Måns Rullgård <mans@mansr.com> - 2016-11-04 18:00 +0100
Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level Sebastian Frias <sf84@laposte.net> - 2016-11-09 14:10 +0100
Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level Florian Fainelli <f.fainelli@gmail.com> - 2016-11-09 18:10 +0100
Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level Andrew Lunn <andrew@lunn.ch> - 2016-11-04 16:20 +0100
Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level Sebastian Frias <sf84@laposte.net> - 2016-11-04 16:30 +0100
Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level Måns Rullgård <mans@mansr.com> - 2016-11-04 16:30 +0100
csiph-web