Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1515240
| From | Sebastian Frias <sf84@laposte.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/2] net: ethernet: nb8800: handle all RGMII declinations |
| Date | 2016-11-04 16:10 +0100 |
| Message-ID | <szOhX-3pW-17@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
Commit a999589ccaae ("phylib: add RGMII-ID interface mode definition")
and commit 7d400a4c5897 ("phylib: add PHY interface modes for internal
delay for tx and rx only") added several RGMII declinations:
PHY_INTERFACE_MODE_RGMII_ID, PHY_INTERFACE_MODE_RGMII_RXID and
PHY_INTERFACE_MODE_RGMII_TXID to deal with internal delays.
Those are all RGMII modes (1Gbit) and must be considered that way when
setting the MAC Mode or the Pads Mode for the HW to work properly.
Signed-off-by: Sebastian Frias <sf84@laposte.net>
---
drivers/net/ethernet/aurora/nb8800.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
index d2855c9..6230ace 100644
--- a/drivers/net/ethernet/aurora/nb8800.c
+++ b/drivers/net/ethernet/aurora/nb8800.c
@@ -609,7 +609,10 @@ static void nb8800_mac_config(struct net_device *dev)
mac_mode |= HALF_DUPLEX;
if (gigabit) {
- if (priv->phy_mode == PHY_INTERFACE_MODE_RGMII)
+ if (priv->phy_mode == PHY_INTERFACE_MODE_RGMII ||
+ priv->phy_mode == PHY_INTERFACE_MODE_RGMII_ID ||
+ priv->phy_mode == PHY_INTERFACE_MODE_RGMII_RXID ||
+ priv->phy_mode == PHY_INTERFACE_MODE_RGMII_TXID)
mac_mode |= RGMII_MODE;
mac_mode |= GMAC_MODE;
@@ -1278,9 +1281,8 @@ static int nb8800_tangox_init(struct net_device *dev)
break;
case PHY_INTERFACE_MODE_RGMII:
- pad_mode = PAD_MODE_RGMII;
- break;
-
+ case PHY_INTERFACE_MODE_RGMII_ID:
+ case PHY_INTERFACE_MODE_RGMII_RXID:
case PHY_INTERFACE_MODE_RGMII_TXID:
pad_mode = PAD_MODE_RGMII;
break;
--
1.7.11.2
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 2/2] net: ethernet: nb8800: handle all RGMII declinations Sebastian Frias <sf84@laposte.net> - 2016-11-04 16:10 +0100
Re: [PATCH 2/2] net: ethernet: nb8800: handle all RGMII declinations Florian Fainelli <f.fainelli@gmail.com> - 2016-11-04 17:30 +0100
Re: [PATCH 2/2] net: ethernet: nb8800: handle all RGMII declinations Sebastian Frias <sf84@laposte.net> - 2016-11-04 17:30 +0100
[PATCH v2 2/2 ] net: ethernet: nb8800: handle all RGMII definitions Sebastian Frias <sf84@laposte.net> - 2016-11-04 18:10 +0100
Re: [PATCH v2 2/2 ] net: ethernet: nb8800: handle all RGMII definitions Måns Rullgård <mans@mansr.com> - 2016-11-04 18:20 +0100
Re: [PATCH v2 2/2 ] net: ethernet: nb8800: handle all RGMII definitions David Miller <davem@davemloft.net> - 2016-11-04 19:00 +0100
Re: [PATCH v2 2/2 ] net: ethernet: nb8800: handle all RGMII definitions Sebastian Frias <sf84@laposte.net> - 2016-11-04 19:30 +0100
csiph-web