Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level

From	Måns Rullgård <mans@mansr.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level
Date	2016-11-04 16:30 +0100
Message-ID	<szOBj-3x3-25@gated-at.bofh.it> (permalink)
References	<szOhX-3pW-7@gated-at.bofh.it> <szOrD-3u0-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Andrew Lunn <andrew@lunn.ch> writes:

> On Fri, Nov 04, 2016 at 04:02:24PM +0100, Sebastian Frias wrote:
>> The delay can be applied at PHY or MAC level, but since
>> PHY drivers will apply the delay at PHY level when using
>> one of the "internal delay" declinations of RGMII mode
>> (like PHY_INTERFACE_MODE_RGMII_TXID), applying it again
>> at MAC level causes issues.

If this is correct, most of the PHY drivers are broken.

>> Signed-off-by: Sebastian Frias <sf84@laposte.net>
>> ---
>>  drivers/net/ethernet/aurora/nb8800.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
>> index b59aa35..d2855c9 100644
>> --- a/drivers/net/ethernet/aurora/nb8800.c
>> +++ b/drivers/net/ethernet/aurora/nb8800.c
>> @@ -1282,7 +1282,7 @@ static int nb8800_tangox_init(struct net_device *dev)
>>  		break;
>>  
>>  	case PHY_INTERFACE_MODE_RGMII_TXID:
>> -		pad_mode = PAD_MODE_RGMII | PAD_MODE_GTX_CLK_DELAY;
>> +		pad_mode = PAD_MODE_RGMII;
>>  		break;
>
> How many boards use this Ethernet driver? How many boards are your
> potentially breaking, because they need this delay?
>
> I guess it is a small number, because doesn't it require the PHY is
> also broken, not adding a delay when it should?

What if the PHY doesn't have that option?

-- 
Måns Rullgård

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level Sebastian Frias <sf84@laposte.net> - 2016-11-04 16:10 +0100
  Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level Måns Rullgård <mans@mansr.com> - 2016-11-04 16:20 +0100
    Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC  level Sebastian Frias <sf84@laposte.net> - 2016-11-04 16:40 +0100
      Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC  level Florian Fainelli <f.fainelli@gmail.com> - 2016-11-04 17:30 +0100
        Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level Måns Rullgård <mans@mansr.com> - 2016-11-04 18:00 +0100
          Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC  level Sebastian Frias <sf84@laposte.net> - 2016-11-09 14:10 +0100
            Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC  level Florian Fainelli <f.fainelli@gmail.com> - 2016-11-09 18:10 +0100
  Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC  level Andrew Lunn <andrew@lunn.ch> - 2016-11-04 16:20 +0100
    Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC  level Sebastian Frias <sf84@laposte.net> - 2016-11-04 16:30 +0100
    Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level Måns Rullgård <mans@mansr.com> - 2016-11-04 16:30 +0100

csiph-web