Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1513156

Re: [PATCH v2 03/10] pwm: imx: Rewrite imx_pwm_*_v1 code to facilitate switch to atomic pwm operation

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Sascha

> On Tue, Nov 01, 2016 at 06:57:23AM +0100, Lukasz Majewski wrote:
> > Hi Sascha,
> > 
> > > The current assumption as discussed by Philipp and me is that the
> > > ipg clk is only needed when the pwm output is driven by the ipg
> > > clk (MX3_PWMCR[16:17] = MX3_PWMCR_CLKSRC_IPG)
> > 
> > At least on my setup (i.MX6q) the ipg clock (ipg_clk) don't need to
> > be explicitly enabled in the ->apply() callback (in the pwm-imx.c)
> > when MX3_PWMCR_CLKSRC_IPG (0x01 - ipg_clk) is selected as the PWM
> > source.
> 
> No. If you look in the device tree you'll see that there is no special
> gateable ipg clock for the PWM. Instead the SoC ipg clock is
> registered for the PWM which is not gateable.

I do understand that the goal is to enable ipg clock only on demand
(when we access registers) and just wanted to say that the approach with
ipg enabled in dts works on my setup (and for now is sufficient).

I suppose that ipg gating support for PWM will be provided in a separate
patch.

> 
> Sascha
> 

Best regards,

Łukasz Majewski

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/10] pwm: imx: Provide atomic operation for IMX PWM driver Lukasz Majewski <l.majewski@majess.pl> - 2016-10-27 08:40 +0200
  [PATCH v2 06/10] pwm: imx: Provide atomic PWM support for i.MX PWMv2 Lukasz Majewski <l.majewski@majess.pl> - 2016-10-27 08:40 +0200
  [PATCH v2 04/10] pwm: imx: Move PWMv2 software reset code to a separate function Lukasz Majewski <l.majewski@majess.pl> - 2016-10-27 08:40 +0200
    Re: [PATCH v2 04/10] pwm: imx: Move PWMv2 software reset code to a  separate function Philipp Zabel <p.zabel@pengutronix.de> - 2016-11-03 10:40 +0100
  [PATCH v2 02/10] pwm: imx: Add separate set of pwm ops for PWMv1 and PWMv2 Lukasz Majewski <l.majewski@majess.pl> - 2016-10-27 08:40 +0200
  [PATCH v2 05/10] pwm: imx: Move PWMv2 wait for fifo slot code to a separate function Lukasz Majewski <l.majewski@majess.pl> - 2016-10-27 08:50 +0200
  [PATCH v2 03/10] pwm: imx: Rewrite imx_pwm_*_v1 code to facilitate switch to atomic pwm operation Lukasz Majewski <l.majewski@majess.pl> - 2016-10-27 08:50 +0200
    Re: [PATCH v2 03/10] pwm: imx: Rewrite imx_pwm_*_v1 code to  facilitate switch to atomic pwm operation Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-10-27 09:50 +0200
      Re: [PATCH v2 03/10] pwm: imx: Rewrite imx_pwm_*_v1 code to  facilitate switch to atomic pwm operation Lukasz Majewski <l.majewski@majess.pl> - 2016-10-27 16:40 +0200
      Re: [PATCH v2 03/10] pwm: imx: Rewrite imx_pwm_*_v1 code to  facilitate switch to atomic pwm operation Sascha Hauer <s.hauer@pengutronix.de> - 2016-10-31 07:10 +0100
        Re: [PATCH v2 03/10] pwm: imx: Rewrite imx_pwm_*_v1 code to  facilitate switch to atomic pwm operation Lukasz Majewski <l.majewski@majess.pl> - 2016-10-31 09:20 +0100
          Re: [PATCH v2 03/10] pwm: imx: Rewrite imx_pwm_*_v1 code to  facilitate switch to atomic pwm operation Sascha Hauer <s.hauer@pengutronix.de> - 2016-10-31 10:30 +0100
        Re: [PATCH v2 03/10] pwm: imx: Rewrite imx_pwm_*_v1 code to  facilitate switch to atomic pwm operation Sascha Hauer <s.hauer@pengutronix.de> - 2016-10-31 10:40 +0100
          Re: [PATCH v2 03/10] pwm: imx: Rewrite imx_pwm_*_v1 code to  facilitate switch to atomic pwm operation Lukasz Majewski <l.majewski@majess.pl> - 2016-10-31 13:00 +0100
          Re: [PATCH v2 03/10] pwm: imx: Rewrite imx_pwm_*_v1 code to  facilitate switch to atomic pwm operation Lukasz Majewski <l.majewski@majess.pl> - 2016-11-01 07:00 +0100
            Re: [PATCH v2 03/10] pwm: imx: Rewrite imx_pwm_*_v1 code to  facilitate switch to atomic pwm operation Sascha Hauer <s.hauer@pengutronix.de> - 2016-11-01 08:20 +0100
              Re: [PATCH v2 03/10] pwm: imx: Rewrite imx_pwm_*_v1 code to  facilitate switch to atomic pwm operation Lukasz Majewski <l.majewski@majess.pl> - 2016-11-01 09:30 +0100
          Re: [PATCH v2 03/10] pwm: imx: Rewrite imx_pwm_*_v1 code to  facilitate switch to atomic pwm operation Sascha Hauer <s.hauer@pengutronix.de> - 2016-11-01 10:00 +0100
        Re: [PATCH v2 03/10] pwm: imx: Rewrite imx_pwm_*_v1 code to  facilitate switch to atomic pwm operation Lothar Waßmann <LW@KARO-electronics.de> - 2016-11-02 08:40 +0100
          Re: [PATCH v2 03/10] pwm: imx: Rewrite imx_pwm_*_v1 code to  facilitate switch to atomic pwm operation Sascha Hauer <s.hauer@pengutronix.de> - 2016-11-02 08:40 +0100
            Re: [PATCH v2 03/10] pwm: imx: Rewrite imx_pwm_*_v1 code to  facilitate switch to atomic pwm operation Lothar Waßmann <LW@KARO-electronics.de> - 2016-11-02 09:00 +0100
              Re: [PATCH v2 03/10] pwm: imx: Rewrite imx_pwm_*_v1 code to  facilitate switch to atomic pwm operation Sascha Hauer <s.hauer@pengutronix.de> - 2016-11-02 09:10 +0100
                Re: [PATCH v2 03/10] pwm: imx: Rewrite imx_pwm_*_v1 code to  facilitate switch to atomic pwm operation Lothar Waßmann <LW@KARO-electronics.de> - 2016-11-02 10:00 +0100
                Re: [PATCH v2 03/10] pwm: imx: Rewrite imx_pwm_*_v1 code to  facilitate switch to atomic pwm operation Philipp Zabel <p.zabel@pengutronix.de> - 2016-11-02 10:40 +0100
  [PATCH v2 08/10] pwm: core: make the PWM_POLARITY flag in DTB optional Lukasz Majewski <l.majewski@majess.pl> - 2016-10-27 08:50 +0200
  [PATCH v2 10/10] pwm: imx: Add polarity inversion support to i.MX's PWMv2 Lukasz Majewski <l.majewski@majess.pl> - 2016-10-27 08:50 +0200
  [PATCH v2 07/10] pwm: imx: Remove redundant i.MX PWMv2 code Lukasz Majewski <l.majewski@majess.pl> - 2016-10-27 08:50 +0200

csiph-web