Re: [PATCH v14 1/9] clocksource/drivers/arm_arch_timer: Move enums and defines to header file

From	Fu Wei <fu.wei@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v14 1/9] clocksource/drivers/arm_arch_timer: Move enums and defines to header file
Date	2016-10-26 13:00 +0200
Message-ID	<swu65-2w2-15@gated-at.bofh.it> (permalink)
References	<smrCx-1LD-3@gated-at.bofh.it> <smrMf-1Po-61@gated-at.bofh.it> <sumPn-t0-7@gated-at.bofh.it> <swrUC-18W-19@gated-at.bofh.it> <swu65-2w2-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Mark

On 26 October 2016 at 18:51, Mark Rutland <mark.rutland@arm.com> wrote:
> On Wed, Oct 26, 2016 at 04:31:55PM +0800, Fu Wei wrote:
>> On 20 October 2016 at 22:45, Mark Rutland <mark.rutland@arm.com> wrote:
>> > On Thu, Sep 29, 2016 at 02:17:09AM +0800, fu.wei@linaro.org wrote:
>> >>  #include <linux/timecounter.h>
>> >>  #include <linux/types.h>
>> >>
>> >> +#define ARCH_CP15_TIMER                      BIT(0)
>> >> +#define ARCH_MEM_TIMER                       BIT(1)
>> >
>> > If we're going to expose these in a header, it would be better to rename
>> > them to something that makes their usage/meaning clear. These should
>> > probably be ARCH_TIMER_TYPE_{CP15,MEM}.
>
>> > With those changes (regardless of the ARCH_TIMER_TYPE_* bits):
>> >
>> > Acked-by: Mark Rutland <mark.rutland@arm.com>
>>
>> For ARCH_TIMER_TYPE_*, maybe I should add a patch at the end of this
>> patchset to fix it, OK ?
>
> Sure. If you could put that *earlier* in the patchset it would be
> preferable so as to minimize churn.

OK, NP, will do

>
> Thanks,
> Mark.



-- 
Best regards,

Fu Wei
Software Engineer
Red Hat

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v14 1/9] clocksource/drivers/arm_arch_timer: Move enums  and defines to header file Mark Rutland <mark.rutland@arm.com> - 2016-10-20 16:50 +0200
  Re: [PATCH v14 1/9] clocksource/drivers/arm_arch_timer: Move enums  and defines to header file Fu Wei <fu.wei@linaro.org> - 2016-10-26 10:40 +0200
    Re: [PATCH v14 1/9] clocksource/drivers/arm_arch_timer: Move enums  and defines to header file Mark Rutland <mark.rutland@arm.com> - 2016-10-26 13:00 +0200
      Re: [PATCH v14 1/9] clocksource/drivers/arm_arch_timer: Move enums  and defines to header file Fu Wei <fu.wei@linaro.org> - 2016-10-26 13:00 +0200

csiph-web