Re: [PATCH 2/5] ARM: davinci: Don't append git rev to local version

From	Sekhar Nori <nsekhar@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/5] ARM: davinci: Don't append git rev to local version
Date	2016-10-26 13:00 +0200
Message-ID	<swu65-2w2-3@gated-at.bofh.it> (permalink)
References	<suMTw-Zb-7@gated-at.bofh.it> <suMTw-Zb-9@gated-at.bofh.it> <svLLI-6ZR-23@gated-at.bofh.it> <svPcC-SB-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Monday 24 October 2016 08:45 PM, David Lechner wrote:
> On 10/24/2016 06:35 AM, Sekhar Nori wrote:
>> On Saturday 22 October 2016 12:06 AM, David Lechner wrote:
>>> In the davinci default configuration, don't append the git revision to
>>> the local kernel version by. This seems like the more desirable default
>>> value.
>>
>> Why? To the contrary I actually quite like the fact that the git commit
>> is appended to version string. Makes it easy for me to cross-check that
>> I am booting the right image.
>>
>>>
>>> Signed-off-by: David Lechner <david@lechnology.com>
>>
>> Thanks,
>> Sekhar
>>
> 
> Each time you make a commit, you get a new version, which installs
> another copy of the kernel modules on the device. This will fill up the
> SD card if you are making many commits.

Right, but thats easily fixable by removing existing modules before
installing new ones.

> Also, if someone wants to build the mainline kernel using the default
> configuration, it seems odd to have a git revision tacked on to the end
> even though you made no revisions.

If you checkout a tag and build, then no commit information is added.
Which I guess is what most end users will do.

I don't see this done in other defconfigs like omap2plus and multi_v7 as
well. I would like to keep it similar for davinci.

Thanks,
Sekhar

Thread

[PATCH 2/5] ARM: davinci: Don't append git rev to local version David Lechner <david@lechnology.com> - 2016-10-21 20:40 +0200
  Re: [PATCH 2/5] ARM: davinci: Don't append git rev to local version Sekhar Nori <nsekhar@ti.com> - 2016-10-24 13:40 +0200
    Re: [PATCH 2/5] ARM: davinci: Don't append git rev to local version David Lechner <david@lechnology.com> - 2016-10-24 17:20 +0200
      Re: [PATCH 2/5] ARM: davinci: Don't append git rev to local version Sekhar Nori <nsekhar@ti.com> - 2016-10-26 13:00 +0200
        Re: [PATCH 2/5] ARM: davinci: Don't append git rev to local version David Lechner <david@lechnology.com> - 2016-10-26 17:50 +0200

csiph-web