Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1505300
| From | Tim Chen <tim.c.chen@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v6 9/9] cpufreq: intel_pstate: Use CPPC to get max performance |
| Date | 2016-10-21 00:10 +0200 |
| Message-ID | <sutHc-52m-29@gated-at.bofh.it> (permalink) |
| References | <sutHb-52m-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This change uses acpi cppc_lib interface to get CPPC performance limits
and calls scheduler interface to update per cpu highest priority. If
there is a difference in highest performance of each CPUs, call scheduler
interface to enable ITMT feature for only one time.
Here sched_set_itmt_core_prio() is called to set priorities and
sched_set_itmt_support() is called to enable ITMT feature.
Original-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Tim Chen <tim.c.chen@linux.intel.com>
---
drivers/cpufreq/Kconfig.x86 | 1 +
drivers/cpufreq/intel_pstate.c | 56 +++++++++++++++++++++++++++++++++++++++++-
2 files changed, 56 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/Kconfig.x86 b/drivers/cpufreq/Kconfig.x86
index adbd1de..c6d273b 100644
--- a/drivers/cpufreq/Kconfig.x86
+++ b/drivers/cpufreq/Kconfig.x86
@@ -6,6 +6,7 @@ config X86_INTEL_PSTATE
bool "Intel P state control"
depends on X86
select ACPI_PROCESSOR if ACPI
+ select ACPI_CPPC_LIB if X86_64 && ACPI && SCHED_ITMT
help
This driver provides a P state for Intel core processors.
The driver implements an internal governor and will become
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index f535f81..5a83a6c 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -44,6 +44,7 @@
#ifdef CONFIG_ACPI
#include <acpi/processor.h>
+#include <acpi/cppc_acpi.h>
#endif
#define FRAC_BITS 8
@@ -377,14 +378,67 @@ static bool intel_pstate_get_ppc_enable_status(void)
return acpi_ppc;
}
+#ifdef CONFIG_SCHED_ITMT
+
+/* The work item is needed to avoid CPU hotplug locking issues */
+static void intel_pstste_sched_itmt_work_fn(struct work_struct *work)
+{
+ sched_set_itmt_support();
+}
+
+static DECLARE_WORK(sched_itmt_work, intel_pstste_sched_itmt_work_fn);
+
+static void intel_pstate_set_itmt_prio(int cpu)
+{
+ struct cppc_perf_caps cppc_perf;
+ static u32 max_highest_perf = 0, min_highest_perf = U32_MAX;
+ int ret;
+
+ ret = cppc_get_perf_caps(cpu, &cppc_perf);
+ if (ret)
+ return;
+
+ /*
+ * The priorities can be set regardless of whether or not
+ * sched_set_itmt_support(true) has been called and it is valid to
+ * update them at any time after it has been called.
+ */
+ sched_set_itmt_core_prio(cppc_perf.highest_perf, cpu);
+
+ if (max_highest_perf <= min_highest_perf) {
+ if (cppc_perf.highest_perf > max_highest_perf)
+ max_highest_perf = cppc_perf.highest_perf;
+
+ if (cppc_perf.highest_perf < min_highest_perf)
+ min_highest_perf = cppc_perf.highest_perf;
+
+ if (max_highest_perf > min_highest_perf) {
+ /*
+ * This code can be run during CPU online under the
+ * CPU hotplug locks, so sched_set_itmt_support()
+ * cannot be called from here. Queue up a work item
+ * to invoke it.
+ */
+ schedule_work(&sched_itmt_work);
+ }
+ }
+}
+#else
+static void intel_pstate_set_itmt_prio(int cpu)
+{
+}
+#endif
+
static void intel_pstate_init_acpi_perf_limits(struct cpufreq_policy *policy)
{
struct cpudata *cpu;
int ret;
int i;
- if (hwp_active)
+ if (hwp_active) {
+ intel_pstate_set_itmt_prio(policy->cpu);
return;
+ }
if (!intel_pstate_get_ppc_enable_status())
return;
--
2.5.5
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v6 0/9] Support Intel® Turbo Boost Max Technology 3.0 Tim Chen <tim.c.chen@linux.intel.com> - 2016-10-21 00:10 +0200
[PATCH v6 8/9] acpi: bus: Set _OSC for diverse core support Tim Chen <tim.c.chen@linux.intel.com> - 2016-10-21 00:10 +0200
[PATCH v6 2/9] x86/topology: Provide topology_num_packages() Tim Chen <tim.c.chen@linux.intel.com> - 2016-10-21 00:10 +0200
[PATCH v6 4/9] x86: Enable Intel Turbo Boost Max Technology 3.0 Tim Chen <tim.c.chen@linux.intel.com> - 2016-10-21 00:10 +0200
[PATCH v6 3/9] x86/topology: Define x86's arch_update_cpu_topology Tim Chen <tim.c.chen@linux.intel.com> - 2016-10-21 00:10 +0200
[PATCH v6 5/9] x86/sysctl: Add sysctl for ITMT scheduling feature Tim Chen <tim.c.chen@linux.intel.com> - 2016-10-21 00:10 +0200
Re: [PATCH v6 5/9] x86/sysctl: Add sysctl for ITMT scheduling feature Thomas Gleixner <tglx@linutronix.de> - 2016-10-26 13:00 +0200
Re: [PATCH v6 5/9] x86/sysctl: Add sysctl for ITMT scheduling feature Tim Chen <tim.c.chen@linux.intel.com> - 2016-10-26 20:10 +0200
Re: [PATCH v6 5/9] x86/sysctl: Add sysctl for ITMT scheduling feature Thomas Gleixner <tglx@linutronix.de> - 2016-10-26 20:20 +0200
Re: [PATCH v6 5/9] x86/sysctl: Add sysctl for ITMT scheduling feature Tim Chen <tim.c.chen@linux.intel.com> - 2016-10-26 21:40 +0200
Re: [PATCH v6 5/9] x86/sysctl: Add sysctl for ITMT scheduling feature Thomas Gleixner <tglx@linutronix.de> - 2016-10-26 13:00 +0200
Re: [PATCH v6 5/9] x86/sysctl: Add sysctl for ITMT scheduling feature Thomas Gleixner <tglx@linutronix.de> - 2016-10-26 13:30 +0200
Re: [PATCH v6 5/9] x86/sysctl: Add sysctl for ITMT scheduling feature Tim Chen <tim.c.chen@linux.intel.com> - 2016-10-26 19:30 +0200
Re: [PATCH v6 5/9] x86/sysctl: Add sysctl for ITMT scheduling feature Thomas Gleixner <tglx@linutronix.de> - 2016-10-26 20:20 +0200
Re: [PATCH v6 5/9] x86/sysctl: Add sysctl for ITMT scheduling feature Peter Zijlstra <peterz@infradead.org> - 2016-10-26 13:30 +0200
Re: [PATCH v6 5/9] x86/sysctl: Add sysctl for ITMT scheduling feature Tim Chen <tim.c.chen@linux.intel.com> - 2016-10-26 20:10 +0200
[PATCH v6 1/9] sched: Extend scheduler's asym packing Tim Chen <tim.c.chen@linux.intel.com> - 2016-10-21 00:10 +0200
Re: [PATCH v6 1/9] sched: Extend scheduler's asym packing Thomas Gleixner <tglx@linutronix.de> - 2016-10-26 12:40 +0200
Re: [PATCH v6 1/9] sched: Extend scheduler's asym packing Tim Chen <tim.c.chen@linux.intel.com> - 2016-10-26 20:20 +0200
Re: [PATCH v6 1/9] sched: Extend scheduler's asym packing Thomas Gleixner <tglx@linutronix.de> - 2016-10-26 20:30 +0200
[PATCH v6 7/9] acpi: bus: Enable HWP CPPC objects Tim Chen <tim.c.chen@linux.intel.com> - 2016-10-21 00:10 +0200
[PATCH v6 9/9] cpufreq: intel_pstate: Use CPPC to get max performance Tim Chen <tim.c.chen@linux.intel.com> - 2016-10-21 00:10 +0200
[PATCH v6 6/9] x86/sched: Add SD_ASYM_PACKING flags to x86 ITMT CPU Tim Chen <tim.c.chen@linux.intel.com> - 2016-10-21 00:10 +0200
csiph-web