Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices
Date	Thu, 20 Oct 2016 16:10:01 +0200
Message-ID	<sumcF-ed-3@gated-at.bofh.it> (permalink)
References	<sjvsZ-4Ti-3@gated-at.bofh.it> <sjJPj-5V2-7@gated-at.bofh.it> <sjKBH-6bG-25@gated-at.bofh.it> <sjKV3-6zb-3@gated-at.bofh.it> <sjKV3-6zb-1@gated-at.bofh.it> <sjL4J-6Cq-9@gated-at.bofh.it> <sjL4J-6Cq-7@gated-at.bofh.it>
X-Original-To	Boris Brezillon <boris.brezillon@free-electrons.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=g/VfzhUeicproIyUgaVdEra227m4qkw9MAT/NJVBxAo=; b=thseQLUl4qyvAxtAnDbIhPF+u/eFTWyZKqeXXAyC+01q+OMma08Eg6ThwpOqEU8iYO Q38NW3d4kB3yM7Dv043SsMqUw3T3uycMzQQtAqic1Mw0PPeY0tKr++z+Uiwk5jwUOQ18 +azDIzlCo2JblX+FeHXYC3fEqadKewV1FUOHu0gEcfXjK4pK+gpQdEinWzxumLI1WDih tZH4gpR1zOxsTCAdNcS8O/OS2iRvuKBcIu9676jLyj3dQscPBWfl7P898Yf5NYIXx0hX H5l0Wxpp77ozeat0jBrSLPOnxfcZY/tLCVld41yzOgvVLWbATZ+hNJkxZ7v12CVr3++8 +sRw==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=g/VfzhUeicproIyUgaVdEra227m4qkw9MAT/NJVBxAo=; b=fG6eOnzkEE3VQU3Z7EkSvb2PXE6gGua0wN3n4hURcHpTqLIIO1J3wdrZ7/j9wLkwgk BukB7+Ij02gXUNB+VrEsJbgVEK0KGICpjlwXaQVfVk4aMKFwTNr+T1f+jierajWrIbiA QLQ19vtW2Scl1KeX6Yu68LBOO6spypAKH/I0IY36j7w/DWnUsdTKvVrviycL43K65/dy urQQBg4YYGcBq0a4XDi9l6wAxEcqO2rPJ58517nX6YE0qWraRKgUW8dlo6p4Sm2mLhfb FOIgqH1zhoE4LsK+2cHd9SFcdN/AT5A3bEjyLP5U9JKgQ7StOQ5Bk2hXVwcHFfyPQysP xuAw==
X-Gm-Message-State	ABUngveZAAe7klK2b/wdS/D8iQG3Snf4MRVGBbYqvqpCvWd31ll9PoxckzXc4fXxQrJ274MUohCAHIxlM3MGeg==
X-Received	by 10.194.28.5 with SMTP id x5mr536905wjg.63.1476972237930; Thu, 20 Oct 2016 07:03:57 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
Organization	linux.* mail to news gateway
X-Original-Cc	Cyrille Pitchen <cyrille.pitchen@atmel.com>, David Woodhouse <dwmw2@infradead.org>, Brian Norris <computersforpeace@gmail.com>, Javier Martinez Canillas <javier@osg.samsung.com>, Stephen Warren <swarren@nvidia.com>, Jagan Teki <jteki@openedev.com>, Vignesh R <vigneshr@ti.com>, Marek Vasut <marex@denx.de>, Ezequiel García <ezequiel@vanguardiasur.com.ar>, Rafał Miłecki <zajec5@gmail.com>, Furquan Shaikh <furquan@google.com>, "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>, LKML <linux-kernel@vger.kernel.org>
X-Original-Date	Thu, 20 Oct 2016 16:03:37 +0200
X-Original-Message-ID	<CAPybu_0U-j6yrO0oOY99UqdVoSqqzN=2c3MbRV8wosWqhm_8EA@mail.gmail.com>
X-Original-References	<20160920154551.3494-1-ricardo.ribalda@gmail.com> <20160921090704.2cfebfc8@bbrezillon> <CAPybu_0S0juNTNO1eQUbxyvcDR8o8W-69+oK5G_i42Z8CHS+FA@mail.gmail.com> <20160921101420.7ea87f2d@bbrezillon> <CAPybu_1f924DvgT1hSPyEMyD7tTN8Cng=mkq5ydDBBbZqpUtuw@mail.gmail.com> <20160921102137.6ff58bc7@bbrezillon> <CAPybu_2j6vn9y-rOAvs2vp18RvSEe8qkg_r3RdRGNgna7-J31A@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1504916

Show key headers only | View raw

Ping?

On Wed, Sep 21, 2016 at 10:26 AM, Ricardo Ribalda Delgado
<ricardo.ribalda@gmail.com> wrote:
> Hi
>
>>>
>>> Unsinged long is more than enough for s3an. I think v7 is ok.
>>
>> Then, why did you change the spi_nor_s3an_addr_convert() prototype?
>>
>
> Because it is used in spi_nor_read and spi_nor_write, which use loff_t.
>
> I think it is more clean to have only one comment explaining the max
> size of the s3an, instead of having them scattered around. But if
> think that it is better to have unsinged int as prototype I have no
> problem in changing it.
>
> Regards!
>
>
> --
> Ricardo Ribalda



-- 
Ricardo Ribalda

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-10-20 16:10 +0200

csiph-web